HDRP custom passes improvements

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -283,6 +283,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed exposure not being properly handled in ray tracing performance (RTGI and RTR, case 1346383).
 - Fixed the RTAO debug view being broken.
 - Fixed an issue that made camera motion vectors unavailable in custom passes.
+- Fixed the possibility to hide custom pass from the create menu with the HideInInspector attribute.
+- Fixed support of multi-editing on custom pass volumes.
 
 ### Changed
 - Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard

com.unity.render-pipelines.high-definition/Editor/RenderPipeline/CustomPass/CustomPassListSearchWindow.cs

@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System;
+using System.Reflection;
 using UnityEngine;
 using UnityEditor;
 using UnityEditor.Experimental.GraphView;
@@ -46,6 +47,9 @@ public List<SearchTreeEntry> CreateSearchTree(SearchWindowContext context)
                 if (customPassType.IsAbstract)
                     continue;
 
+                if (customPassType.GetCustomAttribute<HideInInspector>() != null)
+                    continue;
+
                 tree.Add(new SearchTreeEntry(new GUIContent(customPassType.Name, icon))
                 {
                     level    = 1,

com.unity.render-pipelines.high-definition/Editor/RenderPipeline/CustomPass/CustomPassVolumeEditor.cs

@@ -11,14 +11,15 @@
 
 namespace UnityEditor.Rendering.HighDefinition
 {
-    [CustomEditor(typeof(CustomPassVolume))]
+    [CustomEditor(typeof(CustomPassVolume)), CanEditMultipleObjects]
     sealed class CustomPassVolumeEditor : Editor
     {
         ReorderableList         m_CustomPassList;
         string                  m_ListName;
         CustomPassVolume        m_Volume;
         MaterialEditor[]        m_MaterialEditors = new MaterialEditor[0];
         int                     m_CustomPassMaterialsHash;
+        bool                    m_SupportListMultiEditing;
 
         const string            k_DefaultListName = "Custom Passes";
 
@@ -161,6 +162,12 @@ void DrawSettingsGUI()
 
         void DrawCustomPassReorderableList()
         {
+            if (targets.OfType<CustomPassVolume>().Count() > 1)
+            {
+                EditorGUILayout.HelpBox("Custom Pass List UI is not supported with multi-selection", MessageType.Warning, true);
+                return;
+            }
+
             // Sanitize list:
             for (int i = 0; i < m_SerializedPassVolume.customPasses.arraySize; i++)
             {
@@ -191,6 +198,7 @@ void CreateReorderableList(SerializedProperty passList)
                 EditorGUI.LabelField(rect, k_DefaultListName, EditorStyles.largeLabel);
             };
 
+            m_CustomPassList.multiSelect = false;
             m_CustomPassList.drawElementCallback = (rect, index, active, focused) => {
                 EditorGUI.BeginChangeCheck();
 
@@ -234,14 +242,17 @@ void CreateReorderableList(SerializedProperty passList)
 
             void AddCustomPass(Type customPassType)
             {
-                Undo.RegisterCompleteObjectUndo(m_Volume, "Add custom pass");
-
-                passList.serializedObject.ApplyModifiedProperties();
-                m_Volume.AddPassOfType(customPassType);
-                UpdateMaterialEditors();
-                passList.serializedObject.Update();
-                // Notify the prefab that something have changed:
-                PrefabUtility.RecordPrefabInstancePropertyModifications(m_Volume);
+                foreach (CustomPassVolume volume in targets)
+                {
+                    Undo.RegisterCompleteObjectUndo(volume, "Add custom pass");
+
+                    passList.serializedObject.ApplyModifiedProperties();
+                    volume.AddPassOfType(customPassType);
+                    UpdateMaterialEditors();
+                    passList.serializedObject.Update();
+                    // Notify the prefab that something have changed:
+                    PrefabUtility.RecordPrefabInstancePropertyModifications(volume);
+                }
             }
         }
 

com.unity.render-pipelines.high-definition/Runtime/Compositor/CustomClear.cs

@@ -9,6 +9,7 @@ namespace UnityEngine.Rendering.HighDefinition.Compositor
     // - Always clears the stencil buffer
     // - Clears the alpha channel if desired
     // - Clears the RGB channel to the color of a texture using a specified stretching mode
+    [HideInInspector]
     internal class CustomClear : CustomPass
     {
         internal class ShaderIDs