Fixed gizmos no longer allocate memory in game view #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
svens-unity
approved these changes
May 27, 2021
phi-lira
approved these changes
May 27, 2021
|
I agree we can skip ABV. Graphics tests will not catch any issue here. |
erikabar
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixed gizmos no longer allocate memory in game view. [case 1328852]
Testing status
Tested if it fixes the case 1328852. As this is UI-likeish fix I think we can skip full ABV.
Also we do not expose gizmo enable/disable to script so I can not think automation for this case.