Fixed gizmos drawing in game view #3272

lukaschod · 2021-01-27T08:23:07Z

Purpose of this PR

Fix gizmos drawing in game view, by enabling copy depth pass in game view when gizmos are on. This way filled depth buffer is passed to gizmos pass.

With gizmos game view (Now it also contained in sampler):

Testing status

Checked if it works with depth prepass.
Checked if it works only with depth copy from opaque pass.
Checked if it works with offscreen target.
QA Pass to check if there is no regression with copy depth pass.

…s depth buffer when gizmos enabled.

lukaschod · 2021-01-27T08:23:33Z

com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

+                    // In game view final target acts as back buffer were target is not flipped
+                    bool isGameViewFinalTarget = (cameraData.cameraType == CameraType.Game && destination == RenderTargetHandle.CameraTarget);
+                    bool yflip = (renderingToTexture && !isGameViewFinalTarget) && SystemInfo.graphicsUVStartsAtTop;
+                    float flipSign = yflip ? -1.0f : 1.0f;


I am not super happy about this, open for suggestions

I'm worried as well a little bit about this one. It would be better if we would fix the cameraData.IsCameraProjectionMatrixFlipped() instead.

You have bool yflip = (renderingToTexture && !isGameViewFinalTarget) && SystemInfo.graphicsUVStartsAtTop;

which is same as (renderingToTexture && SystemInfo.graphicsUVStartsAtTop) && !isGameViewFinalTarget

and renderingToTexture && SystemInfo.GraphicsUVStartsAtTop is same as IsCameraProjectMatrixFlipped

so it could be rewritten as bool yflip = cameraData.IsCameraProjectionMatrixFlipped() && !isGameViewRenderTarget ?

github-actions · 2021-01-27T08:23:38Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

com.unity.render-pipelines.universal/Runtime/ForwardRenderer.cs

phi-lira · 2021-01-27T09:04:32Z

com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

+                    // In game view final target acts as back buffer were target is not flipped
+                    bool isGameViewFinalTarget = (cameraData.cameraType == CameraType.Game && destination == RenderTargetHandle.CameraTarget);
+                    bool yflip = (renderingToTexture && !isGameViewFinalTarget) && SystemInfo.graphicsUVStartsAtTop;
+                    float flipSign = yflip ? -1.0f : 1.0f;


I'm worried as well a little bit about this one. It would be better if we would fix the cameraData.IsCameraProjectionMatrixFlipped() instead.

lukaschod · 2021-01-28T13:15:36Z

Failing tests are known issues that are not related to this PR:

[Yamato] Build VFX_URP on Win_DX11_mono_Linear_Standalone_cache_build_Player on version trun
On demand schedular
https://jira.unity3d.com/browse/URP-704

[Yamato] Universal on Android_OpenGLES3_Standalone_cache_il2cpp_Linear on version trunk
[Yamato] Universal on Android_Vulkan_Standalone_cache_il2cpp_Linear on version trunk
[Yamato] Universal on iPhone_Metal_Standalone_cache_il2cpp_Linear on version trunk
Denoiser
https://jira.unity3d.com/browse/URP-705

…universal/fix-game-view-gizmos

simon-engelbrecht-soerensen

Looking good after fixes! No regressions found.

…universal/fix-game-view-gizmos

lukaschod · 2021-02-18T08:40:16Z

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Funiversal_hybrid-win-dx11.yml%2523Universal_Hybrid_Win_DX11_playmode_mono_Linear_trunk/5377787/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Funiversal_hybrid-win-dx11.yml%2523Universal_Hybrid_Win_DX11_playmode_mono_Linear_trunk/5383550/job
Overall status: FAIL
Reason(s): FAILURE REASON: One or more tests have failed.
Total tests: 37
Failed test count: 3
Successful tests count: 33
Not run tests count: 1

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Funiversal_hybrid-osx-metal.yml%2523Universal_Hybrid_OSX_Metal_playmode_mono_Linear_trunk/5377788/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Funiversal_hybrid-osx-metal.yml%2523Universal_Hybrid_OSX_Metal_playmode_mono_Linear_trunk/5388072/job
Overall status: FAIL
Reason(s): FAILURE REASON: One or more tests have failed.
Total tests: 37
Failed test count: 3
Successful tests count: 33
Not run tests count: 1

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Furp_lighting-iphone-metal.yml%2523URP_Lighting_iPhone_Metal_Standalone_cache_il2cpp_Linear_trunk/5377741/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Furp_lighting-iphone-metal.yml%2523URP_Lighting_iPhone_Metal_Standalone_cache_il2cpp_Linear_trunk/5388009/job
Overall status: FAIL
Reason(s): FAILURE REASON: One or more tests have failed.
Total tests: 37
Failed test count: 1
Successful tests count: 36
Not run tests count: 0

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Furp_foundation-linux-vulkan.yml%2523URP_Foundation_Linux_Vulkan_Standalone_cache_mono_Linear_trunk/5377716/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Furp_foundation-linux-vulkan.yml%2523URP_Foundation_Linux_Vulkan_Standalone_cache_mono_Linear_trunk/5383537/job
Overall status: FAIL
Reason(s): FAILURE REASON: One or more tests have failed.
Total tests: 74
Failed test count: 2
Successful tests count: 71
Not run tests count: 1

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Furp_foundation-android-vulkan.yml%2523URP_Foundation_Android_Vulkan_Standalone_cache_il2cpp_Linear_trunk/5377720/job
Disrupted

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Ffix-game-view-gizmos/.yamato%252Fvfx_urp-win-dx11.yml%2523Build_VFX_URP_Win_DX11_Standalone_cache_mono_Linear_trunk/5377790/job
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Fvfx_urp-win-dx11.yml%2523Build_VFX_URP_Win_DX11_Standalone_cache_mono_Linear_trunk/5388750/job
Overall status: FAIL
Reason(s): FAILURE REASON: One or more non-test related errors or failures occurred.
Total tests: 0
Failed test count: 0
Successful tests count: 0
Not run tests count: 0

(1302504) Fixed gizmos drawing in game view. Game view now also copie…

3986113

…s depth buffer when gizmos enabled.

lukaschod requested a review from a team as a code owner January 27, 2021 08:23

github-actions bot added the universal label Jan 27, 2021

lukaschod commented Jan 27, 2021

View reviewed changes

lukaschod requested a review from phi-lira January 27, 2021 08:23

lukaschod added 4 commits January 27, 2021 10:40

(1302504) Fixed gizmos drawing in game view v2

bd3235a

Removing leftover

3b00bb0

Adding sampler to gizmos drawing

bf34c25

Renaming property from m_SceneViewDepthCopyPass to m_FinalDepthCopyPass

fa0a568

phi-lira suggested changes Jan 27, 2021

View reviewed changes

lukaschod added 2 commits January 27, 2021 11:33

Changing back to IsCameraProjectionMatrixFlipped for simplicity

9af6163

Adding guards for editor only code

5e9eec8

lukaschod requested a review from a team January 28, 2021 14:05

phi-lira approved these changes Feb 1, 2021

View reviewed changes

simon-engelbrecht-soerensen requested review from simon-engelbrecht-soerensen and removed request for a team February 3, 2021 07:56

lukaschod added 3 commits February 4, 2021 16:35

Fixing isGizmosEnabled to check ShouldRenderGizmos in editor

6739d03

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

1a14b72

…universal/fix-game-view-gizmos

Mixing depth copy for gizmos to work with mssa

29f5ab3

simon-engelbrecht-soerensen approved these changes Feb 5, 2021

View reviewed changes

lukaschod added 3 commits February 8, 2021 11:09

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

d4a3f01

…universal/fix-game-view-gizmos

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

1b13148

…universal/fix-game-view-gizmos

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

65bcaf9

…universal/fix-game-view-gizmos

lukaschod merged commit 415113c into master Feb 18, 2021

lukaschod deleted the universal/fix-game-view-gizmos branch February 18, 2021 12:11

nigeljw-unity mentioned this pull request Mar 30, 2021

Allow copy depth pass when in game view with gizmos #4034

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed gizmos drawing in game view #3272

Fixed gizmos drawing in game view #3272

Uh oh!

lukaschod commented Jan 27, 2021 •

edited

Loading

Uh oh!

lukaschod Jan 27, 2021

Uh oh!

phi-lira Jan 27, 2021

Uh oh!

phi-lira Jan 27, 2021

Uh oh!

lukaschod Jan 27, 2021

Uh oh!

github-actions bot commented Jan 27, 2021

Uh oh!

Uh oh!

phi-lira Jan 27, 2021

Uh oh!

lukaschod commented Jan 28, 2021

Uh oh!

simon-engelbrecht-soerensen left a comment

Uh oh!

lukaschod commented Feb 18, 2021 •

edited

Loading

Uh oh!

Uh oh!

Fixed gizmos drawing in game view #3272

Fixed gizmos drawing in game view #3272

Uh oh!

Conversation

lukaschod commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Uh oh!

lukaschod Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

phi-lira Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

phi-lira Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

lukaschod Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 27, 2021

Uh oh!

Uh oh!

phi-lira Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

lukaschod commented Jan 28, 2021

Uh oh!

simon-engelbrecht-soerensen left a comment

Choose a reason for hiding this comment

Uh oh!

lukaschod commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lukaschod commented Jan 27, 2021 •

edited

Loading

lukaschod commented Feb 18, 2021 •

edited

Loading