Skip to content

Allow copy depth pass when in game view with gizmos #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

nigeljw-unity
Copy link
Contributor

@nigeljw-unity nigeljw-unity commented Mar 30, 2021

Copy depth pass was being skipped in game view when rendering gizmos so draw order was not being respected.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1302504/


Testing status

Tested against sample provided in case 1302504 and ABV testing


Comments to reviewers

Follow up change for #3272

@nigeljw-unity nigeljw-unity requested a review from lukaschod March 30, 2021 07:55
@nigeljw-unity nigeljw-unity requested review from a team as code owners March 30, 2021 07:55
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@nigeljw-unity nigeljw-unity requested a review from phi-lira March 30, 2021 08:49
Copy link
Contributor

@lukaschod lukaschod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning my mess!!!

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developer tested with repro project, approving

@ellioman
Copy link
Contributor

ellioman commented Apr 6, 2021

The Yamato failures are known and unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants