Fix a useless repaint & fix in editor #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Oct 13, 2020
Merged
|
follow up of #1888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Double perceived performance of HDRP in edit mode
https://docs.google.com/document/d/1xFaK-pFI1XHdngCkXg4HK16x7QJieGy32OMTJf7RpeI/edit
Most fixes will actually be done on this PR:
https://ono.unity3d.com/unity/unity/pull-request/114059/_/graphics/repaint-dirty-fixes
Another change needs to be made but it needs the API added in the PR, so we have to wait for this one
Testing status
Fix a problem that will appear when the c++ PR is merged (currently there is so much repaint that it's not possible to see it)
No more repaints caused by the exposure texture changes (note that there are still lots of repaints anyway so this doesn't make a big difference, but it will)