Skip to content

Fix fullscreen debug pass with XR DX12 #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

adrien-de-tocqueville
Copy link
Contributor


Purpose of this PR

Fixed compilation errors on dx12 with XR mode.
Reorders the input varyings to pixel stage to put system generated semantics as last


Testing status

Reenabled the two fullscreen debug pass tests
Added material with double sided in tests
Unit tests cover the following materials:

  • all hdrp
  • all sg
  • double sided
  • POM displacement
  • transparents

@sebastienlagarde sebastienlagarde marked this pull request as ready for review October 13, 2020 12:27
@adrien-de-tocqueville
Copy link
Contributor Author

I already launched the tests on the first commit, so it should be good (all green)

@sebastienlagarde sebastienlagarde merged commit 2fa1bff into HDRP/staging Oct 13, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-xr-fullscreen-debug branch October 13, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants