Fix render queue migration to 10.x #2198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixed a migration issue with the rendering queue in ShaderGraph when upgrading to 10.x;
Reference: https://unity.slack.com/archives/CC68SH5SB/p1602583588007500?thread_ts=1602287119.003300&cid=CC68SH5SB
Context: The
RenderQueueType
enum doesn't match in 8.x and 10.x so we need an upgrade path to migrate correct values. Affected values are every render queue type abovePreRefraction
8.x:
10.x:
Testing status
I imported a ShaderGraph with Transparent After Post Process rendering pass created in HDRP 8.x to a project with HDRP 10.x, before this fix the SG editor was crashing when opening the surface options in the graph inspector. With this fix the issue is gone and the rendering pass value is correct (Transparent After Post Process)