Skip to content

Fix render queue migration to 10.x #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented Oct 13, 2020

Purpose of this PR

Fixed a migration issue with the rendering queue in ShaderGraph when upgrading to 10.x;

Reference: https://unity.slack.com/archives/CC68SH5SB/p1602583588007500?thread_ts=1602287119.003300&cid=CC68SH5SB
Context: The RenderQueueType enum doesn't match in 8.x and 10.x so we need an upgrade path to migrate correct values. Affected values are every render queue type above PreRefraction

8.x:

        public enum RenderQueueType
        {
            Background,
            // Opaque
            Opaque,
            AfterPostProcessOpaque,
            RaytracingOpaque,
            // Transparent
            PreRefraction,
            Transparent,
            LowTransparent,
            AfterPostprocessTransparent,
            RaytracingTransparent,
            Overlay,
            Unknown
        }

10.x:

        public enum RenderQueueType
        {
            Background,
            // Opaque
            Opaque,
            AfterPostProcessOpaque,
            // Transparent
            PreRefraction,
            Transparent,
            LowTransparent,
            AfterPostprocessTransparent,
            Overlay,
            Unknown
        }

Testing status

I imported a ShaderGraph with Transparent After Post Process rendering pass created in HDRP 8.x to a project with HDRP 10.x, before this fix the SG editor was crashing when opening the surface options in the graph inspector. With this fix the issue is gone and the rendering pass value is correct (Transparent After Post Process)

@alelievr alelievr requested review from sebastienlagarde and a team October 13, 2020 10:51
@alelievr alelievr self-assigned this Oct 13, 2020
@github-actions github-actions bot added the HDRP label Oct 13, 2020
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde removed the request for review from a team October 13, 2020 12:59
@sebastienlagarde
Copy link
Contributor

no need for more QA, have been validated by external users of HDRP.

@sebastienlagarde sebastienlagarde merged commit 26d8a49 into HDRP/staging Oct 13, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/fix/render-queue-migration-to-10 branch October 13, 2020 12:59
sebastienlagarde added a commit that referenced this pull request Oct 14, 2020
@alelievr alelievr mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants