Skip to content

[7.x.x][case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[7.x.x][case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f4ba1d
Add additional restriction to only require sRGB conversion if the act…
todds-unity Sep 24, 2020
e0c13ef
Adding a CHANGELOG entry.
todds-unity Sep 24, 2020
687a72e
Merging 7.x.x/release -> 7.x.x/universal/bugfix-1251402.
todds-unity Sep 28, 2020
2032c36
Merging 7.x.x/release -> 7.x.x/universal/bugfix-1251402.
todds-unity Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed camera backgrounds not matching between editor and build when background is set to 'Uninitialized'. [case 1224369](https://issuetracker.unity3d.com/issues/urp-uninitialized-camera-background-type-does-not-match-between-the-build-and-game-view)
- Fixed an issue where Pixel lighting variants were stripped in builds if another URP asset had Additional Lights set to Per Vertex [case 1263514](https://issuetracker.unity3d.com/issues/urp-all-pixel-lighting-variants-are-stripped-in-build-if-at-least-one-urp-asset-has-additional-lights-set-to-per-vertex)
- Fixed an issue where transparent meshes were rendered opaque when using custom render passes [case 1262887](https://issuetracker.unity3d.com/issues/urp-transparent-meshes-are-rendered-as-opaques-when-using-lit-shader-with-custom-render-pass)
- Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled. [case 1251402](https://issuetracker.unity3d.com/issues/metal-urp-ios-google-vr-ios-white-filter-appears-when-using-fxaa-plus-post-processing-plus-single-pass-stereo-rendering-mode)

## [7.5.1] - 2020-09-02

Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.universal/Runtime/Passes/PostProcessPass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ bool RequireSRGBConversionBlitToBackBuffer(CameraData cameraData)
// If eye texture color format is linear, we do explicit sRGB convertion
#if ENABLE_VR && ENABLE_VR_MODULE
if (cameraData.isStereoEnabled)
requiresSRGBConversion = !XRGraphics.eyeTextureDesc.sRGB;
requiresSRGBConversion = !XRGraphics.eyeTextureDesc.sRGB && (QualitySettings.activeColorSpace == ColorSpace.Linear);
#endif
return requiresSRGBConversion;
}
Expand Down