-
Notifications
You must be signed in to change notification settings - Fork 840
[7.x.x][case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ive color space is linear. Fixes fogbugz #1251402.
Note: the linear colorspace check is already landed in master as part of #22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todds-unity where is the PR to master? we need to land it on master first then backport to other versions. |
Do you have an update on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is entirely contained in XR-side (under defines). LGTM.
Purpose of this PR
Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled. case 1251402
Testing status
Manually tested the change on local mobile devices.