Skip to content

[7.x.x][case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

todds-unity
Copy link

Purpose of this PR

Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled. case 1251402

Testing status

Manually tested the change on local mobile devices.

@todds-unity todds-unity self-assigned this Sep 24, 2020
@thomas-zeng thomas-zeng added the XR label Sep 24, 2020
@thomas-zeng thomas-zeng changed the title [case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled [7.x.x][case 1251402] Fixed an issue where gamma correction was being applied twice for Google VR on iOS devices when FXAA was enabled Sep 24, 2020
@thomas-zeng
Copy link
Contributor

thomas-zeng commented Sep 24, 2020

Note: the linear colorspace check is already landed in master as part of #22

Copy link
Contributor

@thomas-zeng thomas-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

@DiannaUnity DiannaUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 2019.4.8f1 (60781d942082)
Wed, 05 Aug 2020 14:08:36 GMT
Branch: 2019.4/staging

Before fix; the sky and ground is lighter, skybox looks more grey
image

After fix; the scene becomes darker and matches the scene viewer
image

Confirmed that the fix works on iPhone XS.

@todds-unity todds-unity marked this pull request as ready for review September 26, 2020 00:56
@todds-unity todds-unity requested a review from a team as a code owner September 26, 2020 00:56
@phi-lira
Copy link
Contributor

@todds-unity where is the PR to master? we need to land it on master first then backport to other versions.

@phi-lira
Copy link
Contributor

phi-lira commented Nov 26, 2020

Do you have an update on this PR?

Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is entirely contained in XR-side (under defines). LGTM.

@todds-unity todds-unity closed this Feb 9, 2021
@sebastienlagarde sebastienlagarde deleted the 7.x.x/universal/bugfix-1251402 branch September 1, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants