Fix for cross-pipeline work #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Sep 25, 2020
|
Any update on this PR ? |
Should be ready to go, just poking for reviews |
cdxntchou
approved these changes
Sep 28, 2020
phi-lira
approved these changes
Sep 29, 2020
ghost
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to make sure that unrecognized node types are always considered "invalid" by the target. Added a filterable attribute NeverAllowedByTarget and made targets mark that as not allowed by default.
Also, slight conceptual change in node validation - theres a bit of a difference between a node being invalid in a given target context and a node reporting a validation error. A validation error is just saying that the node is setup wrong, whereas a target saying a node is invalid is saying that this node is wrong AND wont generate code because its wrong. That means a node can not say that it is "valid" or not (because valid is used to determine code generation) but it can add validation errors to itself that get reported. Naming might need to be a bit more explicit about this distinction internally.