Skip to content

[10.x.x] Bugfix 1268147: ArgumentOutOfRangeException errors are thrown after removing Render feature #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[10.x.x] Bugfix 1268147: ArgumentOutOfRangeException errors are thrown after removing Render feature #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65753db
Fixed an issue where ArgumentOutOfRangeException errors were thrown a…
ellioman Aug 6, 2020
1994e8b
Merge branch 'master' into universal/bugfix-1268147-rendererfeatures-…
ellioman Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue where terrain and speedtree materials would not get upgraded by upgrade project materials. [case 1204189](https://fogbugz.unity3d.com/f/cases/1204189/)
- Fixed an issue that caused renderer feature to not render correctly if the pass was injected before rendering opaques and didn't implement `Configure` method. [case 1259750](https://issuetracker.unity3d.com/issues/urp-not-rendering-with-a-renderer-feature-before-rendering-shadows)
- Fixed an issue where postFX's temp texture is not released properly.
- Fixed an issue where ArgumentOutOfRangeException errors were thrown after removing Render feature [case 1268147](https://issuetracker.unity3d.com/issues/urp-argumentoutofrangeexception-errors-are-thrown-on-undoing-after-removing-render-feature)

## [7.1.1] - 2019-09-05
### Upgrade Guide
Expand Down
6 changes: 4 additions & 2 deletions com.unity.render-pipelines.universal/Editor/ScriptableRendererDataEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,16 @@ private void OnEnable()
m_RendererFeatures = serializedObject.FindProperty(nameof(ScriptableRendererData.m_RendererFeatures));
m_RendererFeaturesMap = serializedObject.FindProperty(nameof(ScriptableRendererData.m_RendererFeatureMap));
var editorObj = new SerializedObject(this);
m_FalseBool = editorObj.FindProperty(nameof(falseBool));
m_FalseBool = editorObj.FindProperty(nameof(falseBool));
UpdateEditorList();
}

public override void OnInspectorGUI()
{
if(m_RendererFeatures == null)
if (m_RendererFeatures == null)
OnEnable();
else if (m_RendererFeatures.arraySize != m_Editors.Count)
UpdateEditorList();

serializedObject.Update();
DrawRendererFeatureList();
Expand Down