Skip to content

[10.x.x] Bugfix 1268147: ArgumentOutOfRangeException errors are thrown after removing Render feature #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Aug 6, 2020

Purpose of this PR

Fixing issue 1268147 that was introduced with #8
https://issuetracker.unity3d.com/issues/urp-argumentoutofrangeexception-errors-are-thrown-on-undoing-after-removing-render-feature


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@ellioman ellioman requested a review from a team as a code owner August 6, 2020 11:16
@ellioman ellioman requested a review from pbbastian August 6, 2020 11:16
@phi-lira phi-lira removed the request for review from pbbastian August 7, 2020 10:19
@phi-lira phi-lira merged commit d99277a into master Aug 7, 2020
@phi-lira phi-lira deleted the universal/bugfix-1268147-rendererfeatures-undo branch August 7, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants