Universal/depth copy as color #5987

commit 70ad6ee
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Thu Oct 14 15:04:53 2021 +0300

    adding some editor-specific code to avoid a bug with editor setting incorrect depth buffer while on game view

commit 850428a
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Wed Oct 13 12:28:57 2021 +0300

    null exception fix

commit 427e0cb
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Wed Oct 13 10:02:30 2021 +0300

    another DeferredLights null check

commit fcb7d7f
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Tue Oct 12 15:31:42 2021 +0300

    fix for RTIs non render pass platforms

commit 62ca66d
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Oct 12 13:14:55 2021 +0300

    fixing shader compilation error and renaming define for fb fetch idx

commit b5a042f
Merge: 4deded8 f9152cf
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Oct 12 12:11:44 2021 +0300

    Merge branch 'universal/depth-copy-as-color' of ssh://github.com/Unity-Technologies/Graphics into universal/depth-copy-as-color

commit f9152cf
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Tue Oct 12 12:07:03 2021 +0300

    adding fb fetch to Gbuffer decals and some other depth related fixes for decals

commit 159580e
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Mon Oct 11 17:37:35 2021 +0300

    fixing DBuffer Decals CopyDepth pass not copying the depth and failing rendering

commit f95fafb
Merge: c4ddd12 e718a8e
Author: Jonas Sideravičius <jonass@unity3d.com>
Date:   Mon Oct 11 13:45:13 2021 +0300

    Merge branch 'master' into universal/depth-copy-as-color

commit 4deded8
Merge: c4ddd12 1ede825
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Wed Oct 6 16:30:14 2021 +0300

    Merge branch 'master' into universal/depth-copy-as-color

commit c4ddd12
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Wed Aug 25 13:40:27 2021 +0300

    changing the semantic for outDepthColor in VFXPasses.template

commit 5dec840
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Aug 24 11:53:11 2021 +0300

    adding depth output for VFXGraph depth only passes

commit 2510a18
Merge: fd4df44 a938468
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Mon Aug 23 12:00:52 2021 +0300

    Merge branch 'master' into universal/depth-copy-as-color

commit fd4df44
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Aug 19 15:47:23 2021 +0300

    adding _OUTPUT_DEPTH keyword to CopyDepthPass to select correct output buffer in shader

commit 165f4d5
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Aug 17 17:26:19 2021 +0300

    some cleanup and refactoring and enabling Renderpass for SS forward decals

commit 4f9cbd7
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Aug 17 16:02:04 2021 +0300

    adding depth copy for renderpass as well and changing how fake depth is handled

commit 68d3938
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Aug 17 10:33:59 2021 +0300

    terrain shader passes depthonly pass fix to output clippos

commit 399ee75
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Mon Aug 16 16:30:48 2021 +0300

    formatting fixes

commit ee6e7d4
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Mon Aug 16 11:48:25 2021 +0300

    enabling depthbuffer for depth copy and adding additional override for ConfigureTarget

commit 6accb1c
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Fri Aug 13 16:42:23 2021 +0300

    merge fix - change descriptor for DepthOnly configureTarget to the correct one

commit d887392
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Fri Aug 13 16:10:30 2021 +0300

    fix after updating trunk

commit 624f0a1
Merge: 933f089 8ee37d5
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Aug 12 16:53:11 2021 +0300

    Merge branch 'master' into universal/depth-copy-as-color

commit 933f089
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Aug 12 16:43:25 2021 +0300

    making depthOnly pass compatible to render color texture and changing shaders to accommodate that

commit c149ec9
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Aug 5 14:40:21 2021 +0300

    adding IsTransientAttachment to ScriptableRenderPass/NativeRenderPass code

commit d39e96d
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Tue Aug 3 11:59:28 2021 +0300

    disable fbfetch on DbufferDeferred decals

commit d1cef12
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Jul 29 11:57:25 2021 +0300

    Revert "some changes to the Foundation Project for Repro project (to be reverted later on)"

    This reverts commit 80af9be.

commit 80af9be
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Jul 29 11:21:14 2021 +0300

    some changes to the Foundation Project for Repro project (to be reverted later on)

commit a2e4eb6
Author: Jonas Sideravicius <jonass@unity3d.com>
Date:   Thu Jul 29 11:02:07 2021 +0300

    switching _CameraDepthTexture to R32Float and accommodating some stuff for that

Author: phi-lira

TestProjects/UniversalGraphicsTest_Foundation/Assets/Scenes/230_Decals/Materials/Brick.mat

@@ -13,7 +13,7 @@ Material:
   m_LightmapFlags: 4
   m_EnableInstancingVariants: 0
   m_DoubleSidedGI: 0
-  m_CustomRenderQueue: 2000
+  m_CustomRenderQueue: 1999
   stringTagMap:
     RenderType: Opaque
   disabledShaderPasses: []
@@ -95,7 +95,7 @@ Material:
     - _Metallic: 0
     - _OcclusionStrength: 0.387
     - _Parallax: 0.0477
-    - _QueueOffset: 0
+    - _QueueOffset: -1
     - _ReceiveShadows: 1
     - _Smoothness: 0.742
     - _SmoothnessTextureChannel: 0

com.unity.render-pipelines.core/ShaderLibrary/API/Metal.hlsl

@@ -150,7 +150,6 @@
 #define GATHER_GREEN_TEXTURE2D(textureName, samplerName, coord2)          textureName.GatherGreen(samplerName, coord2)
 #define GATHER_BLUE_TEXTURE2D(textureName, samplerName, coord2)           textureName.GatherBlue(samplerName, coord2)
 #define GATHER_ALPHA_TEXTURE2D(textureName, samplerName, coord2)          textureName.GatherAlpha(samplerName, coord2)
-
-#if defined(SHADER_API_MOBILE)
+#if defined(UNITY_FRAMEBUFFER_FETCH_AVAILABLE)
 #define PLATFORM_SUPPORTS_NATIVE_RENDERPASS
 #endif

com.unity.render-pipelines.universal/Editor/Decal/DecalPass.template

@@ -63,7 +63,10 @@ Pass
     #ifdef SCENEPICKINGPASS
     float4 _SelectionID;
     #endif
-
+    #if _RENDER_PASS_ENABLED
+    #define GBUFFER3 0
+    FRAMEBUFFER_INPUT_HALF(GBUFFER3);
+    #endif
     // Includes
     $splice(PreGraphIncludes)
 

com.unity.render-pipelines.universal/Editor/ShaderGraph/Includes/DepthOnlyPass.hlsl

@@ -21,7 +21,7 @@ half4 frag(PackedVaryings packedInput) : SV_TARGET
         clip(surfaceDescription.Alpha - surfaceDescription.AlphaClipThreshold);
     #endif
 
-    return 0;
+    return packedInput.positionCS.z;
 }
 
 #endif

com.unity.render-pipelines.universal/Editor/ShaderGraph/Includes/ShaderPassDecal.hlsl

@@ -181,12 +181,20 @@ void Frag(PackedVaryings packedInput,
 
 #if defined(DECAL_PROJECTOR)
 #if UNITY_REVERSED_Z
+#if _RENDER_PASS_ENABLED
+    float depth = LOAD_FRAMEBUFFER_INPUT(GBUFFER3, input.positionCS.xy);
+#else
     float depth = LoadSceneDepth(input.positionCS.xy);
+#endif
+#else
+#if _RENDER_PASS_ENABLED
+    float depth = lerp(UNITY_NEAR_CLIP_VALUE, 1, LOAD_FRAMEBUFFER_INPUT(GBUFFER3, input.positionCS.xy));
 #else
     // Adjust z to match NDC for OpenGL
     float depth = lerp(UNITY_NEAR_CLIP_VALUE, 1, LoadSceneDepth(input.positionCS.xy));
 #endif
 #endif
+#endif
 
 #if defined(DECAL_RECONSTRUCT_NORMAL)
     #if defined(_DECAL_NORMAL_BLEND_HIGH)

com.unity.render-pipelines.universal/Editor/ShaderGraph/Targets/UniversalDecalSubTarget.cs

@@ -977,6 +977,7 @@ static class Descriptors
                 { CoreKeywordDescriptors.MixedLightingSubtractive },
                 { Descriptors.DecalsNormalBlend },
                 { CoreKeywordDescriptors.GBufferNormalsOct },
+                { CoreKeywordDescriptors.RenderPassEnabled },
                 { Descriptors.LodCrossFade, new FieldCondition(Fields.LodCrossFade, true) },
             };
 
@@ -986,6 +987,7 @@ static class Descriptors
                 { CoreKeywordDescriptors.ShadowsSoft },
                 { Descriptors.DecalsNormalBlend },
                 { CoreKeywordDescriptors.GBufferNormalsOct },
+                { CoreKeywordDescriptors.RenderPassEnabled },
             };
         }
         #endregion

com.unity.render-pipelines.universal/Editor/ShaderGraph/Targets/UniversalTarget.cs

@@ -1242,7 +1242,7 @@ public static RenderStateCollection DepthOnly(UniversalTarget target)
                 { RenderState.ZTest(ZTest.LEqual) },
                 { RenderState.ZWrite(ZWrite.On) },
                 { UberSwitchedCullRenderState(target) },
-                { RenderState.ColorMask("ColorMask 0") },
+                { RenderState.ColorMask("ColorMask R") },
             };
 
             return result;

com.unity.render-pipelines.universal/Editor/VFXGraph/Shaders/VFXPasses.template

@@ -86,6 +86,9 @@ void frag(ps_input i
 #if VFX_PASSDEPTH == VFX_PASSDEPTH_ACTUAL
     #if defined(WRITE_NORMAL_BUFFER)
     , out float4 outNormalBuffer : SV_Target0
+    , out float4 outDepthColor : SV_Target1
+    #else
+    , out float4 outDepthColor : SV_Target0
     #endif
 #elif VFX_PASSDEPTH == VFX_PASSDEPTH_SELECTION
     , out float4 outColor : SV_Target0
@@ -130,7 +133,7 @@ void frag(ps_input i
         // We use depth prepass for scene selection in the editor, this code allow to output the outline correctly
         outColor = float4(_ObjectId, _PassValue, 1.0, 1.0);
     #elif VFX_PASSDEPTH == VFX_PASSDEPTH_ACTUAL
-        //void
+        outDepthColor = float4(i.VFX_VARYING_POSCS.z, 0,0,0);
     #elif VFX_PASSDEPTH == VFX_PASSDEPTH_SHADOW
         //void
     #else

com.unity.render-pipelines.universal/Runtime/Decal/ScreenSpace/DecalGBufferRenderPass.cs

@@ -17,6 +17,7 @@ internal class DecalGBufferRenderPass : ScriptableRenderPass
         private DecalDrawGBufferSystem m_DrawSystem;
         private DecalScreenSpaceSettings m_Settings;
         private DeferredLights m_DeferredLights;
+        private RenderTargetIdentifier[] m_GbufferAttachments;
 
         public DecalGBufferRenderPass(DecalScreenSpaceSettings settings, DecalDrawGBufferSystem drawSystem)
         {
@@ -41,7 +42,20 @@ internal void Setup(DeferredLights deferredLights)
 
         public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData)
         {
-            ConfigureTarget(m_DeferredLights.GbufferAttachmentIdentifiers, m_DeferredLights.DepthAttachmentIdentifier);
+            if (m_DeferredLights != null && m_DeferredLights.UseRenderPass)
+            {
+                if (m_GbufferAttachments == null)
+                    m_GbufferAttachments = new RenderTargetIdentifier[]
+                    {
+                        m_DeferredLights.GbufferAttachmentIdentifiers[0], m_DeferredLights.GbufferAttachmentIdentifiers[1],
+                        m_DeferredLights.GbufferAttachmentIdentifiers[2], m_DeferredLights.GbufferAttachmentIdentifiers[3]
+                    };
+                ConfigureInputAttachments(m_DeferredLights.DepthCopyTextureIdentifier, false);
+            }
+            else
+                m_GbufferAttachments = m_DeferredLights.GbufferAttachmentIdentifiers;
+
+            ConfigureTarget(m_GbufferAttachments, m_DeferredLights.DepthAttachmentIdentifier);
         }
 
         public override void Execute(ScriptableRenderContext context, ref RenderingData renderingData)

com.unity.render-pipelines.universal/Runtime/DeferredLights.cs

@@ -188,6 +188,7 @@ internal bool AccurateGbufferNormals
         // Output lighting result.
         internal RenderTargetHandle[] GbufferAttachments { get; set; }
         internal RenderTargetIdentifier[] DeferredInputAttachments { get; set; }
+        internal bool[] DeferredInputIsTransient { get; set; }
         // Input depth texture, also bound as read-only RT
         internal RenderTargetHandle DepthAttachment { get; set; }
         //
@@ -402,12 +403,17 @@ public void Setup(ref RenderingData renderingData,
                 this.GbufferAttachmentIdentifiers[i] = this.GbufferAttachments[i].Identifier();
                 this.GbufferFormats[i] = this.GetGBufferFormat(i);
             }
-            if (this.DeferredInputAttachments == null && this.UseRenderPass && this.GbufferAttachments.Length >= 5)
+            if (this.DeferredInputAttachments == null && this.UseRenderPass && this.GbufferAttachments.Length >= 3)
             {
                 this.DeferredInputAttachments = new RenderTargetIdentifier[4]
                 {
                     this.GbufferAttachmentIdentifiers[0], this.GbufferAttachmentIdentifiers[1],
-                    this.GbufferAttachmentIdentifiers[2], this.GbufferAttachmentIdentifiers[4]
+                    this.GbufferAttachmentIdentifiers[2], this.DepthCopyTextureIdentifier
+                };
+
+                this.DeferredInputIsTransient = new bool[4]
+                {
+                    true, true, true, false
                 };
             }
             this.DepthAttachmentIdentifier = depthAttachment.Identifier();