switching _CameraDepthTexture to R32Float and accommodating some stuff for that

Author: jonuuukas

com.unity.render-pipelines.universal/Runtime/Decal/ScreenSpace/DecalGBufferRenderPass.cs

@@ -41,7 +41,7 @@ internal void Setup(DeferredLights deferredLights)
 
         public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData)
         {
-            ConfigureTarget(m_DeferredLights.GbufferAttachmentIdentifiers, m_DeferredLights.DepthAttachmentIdentifier);
+            ConfigureTarget(new RenderTargetIdentifier[] {m_DeferredLights.GbufferAttachmentIdentifiers[0], m_DeferredLights.GbufferAttachmentIdentifiers[1], m_DeferredLights.GbufferAttachmentIdentifiers[2], m_DeferredLights.GbufferAttachmentIdentifiers[3]  }, m_DeferredLights.DepthAttachmentIdentifier);
         }
 
         public override void Execute(ScriptableRenderContext context, ref RenderingData renderingData)

com.unity.render-pipelines.universal/Runtime/DeferredLights.cs

@@ -245,7 +245,7 @@ struct DrawCall
             "_GBuffer1",
             "_GBuffer2",
             "_GBuffer3",
-            "_GBuffer4",
+            "_CameraDepthTexture",
             "_GBuffer5",
             "_GBuffer6"
         };

com.unity.render-pipelines.universal/Runtime/NativeRenderPass.cs

@@ -509,9 +509,15 @@ internal void SetupInputAttachmentIndices(ScriptableRenderPass pass)
                     continue;
                 }
 
+                m_ActiveColorAttachmentDescriptors[pass.m_InputAttachmentIndices[i]].loadAction = RenderBufferLoadAction.DontCare;
+
+				// If the attachment doesn't require store - it should be transient
+				if (i >= 3)
+				{
+					return;
+				}
                 // Assume input attachment has to be transient as ScriptableRenderPass currently has only setters for StoreAction
                 // We also change the target of the descriptor for it to be initialized engine-side as a transient resource.
-                m_ActiveColorAttachmentDescriptors[pass.m_InputAttachmentIndices[i]].loadAction = RenderBufferLoadAction.DontCare;
                 m_ActiveColorAttachmentDescriptors[pass.m_InputAttachmentIndices[i]].storeAction = RenderBufferStoreAction.DontCare;
                 m_ActiveColorAttachmentDescriptors[pass.m_InputAttachmentIndices[i]].loadStoreTarget = BuiltinRenderTextureType.None;
             }

com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

@@ -43,14 +43,15 @@ public void Setup(RenderTargetHandle source, RenderTargetHandle destination)
         public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData)
         {
             var descriptor = renderingData.cameraData.cameraTargetDescriptor;
-            descriptor.colorFormat = RenderTextureFormat.Depth;
-            descriptor.depthBufferBits = 32; //TODO: do we really need this. double check;
+            // descriptor.colorFormat = RenderTextureFormat.Depth;
+            descriptor.graphicsFormat = GraphicsFormat.R32_SFloat;
+            descriptor.depthBufferBits = 0; //TODO: do we really need this. double check;
             descriptor.msaaSamples = 1;
             if (this.AllocateRT)
                 cmd.GetTemporaryRT(destination.id, descriptor, FilterMode.Point);
 
             // On Metal iOS, prevent camera attachments to be bound and cleared during this pass.
-            ConfigureTarget(new RenderTargetIdentifier(destination.Identifier(), 0, CubemapFace.Unknown, -1), GraphicsFormat.DepthAuto, descriptor.width, descriptor.height, descriptor.msaaSamples, true);
+            ConfigureTarget(new RenderTargetIdentifier(destination.Identifier(), 0, CubemapFace.Unknown, -1), GraphicsFormat.R32_SFloat, descriptor.width, descriptor.height, descriptor.msaaSamples, false);
             ConfigureClear(ClearFlag.None, Color.black);
         }
 

com.unity.render-pipelines.universal/Runtime/Passes/GBufferPass.cs

@@ -70,14 +70,15 @@ public override void Configure(CommandBuffer cmd, RenderTextureDescriptor camera
                         continue;
 
                     // No need to setup temporaryRTs if we are using input attachments as they will be Memoryless
-                    if (m_DeferredLights.UseRenderPass && i != m_DeferredLights.GBufferShadowMask && i != m_DeferredLights.GBufferRenderingLayers)
+                    if (m_DeferredLights.UseRenderPass && i != m_DeferredLights.GBufferShadowMask && i != m_DeferredLights.GBufferRenderingLayers && i != m_DeferredLights.GbufferDepthIndex)
                         continue;
 
                     RenderTextureDescriptor gbufferSlice = cameraTextureDescriptor;
                     gbufferSlice.depthBufferBits = 0; // make sure no depth surface is actually created
                     gbufferSlice.stencilFormat = GraphicsFormat.None;
                     gbufferSlice.graphicsFormat = m_DeferredLights.GetGBufferFormat(i);
-                    cmd.GetTemporaryRT(m_DeferredLights.GbufferAttachments[i].id, gbufferSlice);
+
+                    cmd.GetTemporaryRT(m_DeferredLights.GbufferAttachments[i].id, gbufferSlice, FilterMode.Point);
                 }
             }
 
@@ -127,6 +128,7 @@ public override void Execute(ScriptableRenderContext context, ref RenderingData
                 // Input attachments will only be used when this is not needed so safe to skip in that case
                 if (!m_DeferredLights.UseRenderPass)
                     gbufferCommands.SetGlobalTexture(s_CameraNormalsTextureID, m_DeferredLights.GbufferAttachmentIdentifiers[m_DeferredLights.GBufferNormalSmoothnessIndex]);
+               // gbufferCommands.SetGlobalTexture("_GBuffer4", m_DeferredLights.GbufferAttachmentIdentifiers[4]);
             }
 
             context.ExecuteCommandBuffer(gbufferCommands);

com.unity.render-pipelines.universal/Runtime/RendererFeatures/DecalRendererFeature.cs

@@ -378,6 +378,7 @@ private void RecreateSystemsIfNeeded(ScriptableRenderer renderer, in CameraData
                 case DecalTechnique.GBuffer:
 
                     m_DeferredLights = universalRenderer.deferredLights;
+                    //m_DeferredLights.DisableFramebufferFetchInput();
 
                     m_CopyDepthPass = new CopyDepthPass(RenderPassEvent.AfterRenderingOpaques, m_DBufferClearMaterial);
                     m_DrawGBufferSystem = new DecalDrawGBufferSystem(m_DecalEntityManager);
@@ -483,6 +484,11 @@ public override void AddRenderPasses(ScriptableRenderer renderer, ref RenderingD
             }
         }
 
+        internal override bool SupportsNativeRenderPass()
+        {
+            return m_Technique == DecalTechnique.GBuffer;
+        }
+
         protected override void Dispose(bool disposing)
         {
             CoreUtils.Destroy(m_CopyDepthMaterial);

com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs

@@ -641,8 +641,8 @@ public override void Setup(ScriptableRenderContext context, ref RenderingData re
 
             if (this.actualRenderingMode == RenderingMode.Deferred)
             {
-                if (m_DeferredLights.UseRenderPass && (RenderPassEvent.AfterRenderingGbuffer == renderPassInputs.requiresDepthNormalAtEvent || !useRenderPassEnabled))
-                    m_DeferredLights.DisableFramebufferFetchInput();
+                // if (m_DeferredLights.UseRenderPass && (RenderPassEvent.AfterRenderingGbuffer == renderPassInputs.requiresDepthNormalAtEvent || !useRenderPassEnabled))
+                //     m_DeferredLights.DisableFramebufferFetchInput();
 
                 EnqueueDeferred(ref renderingData, requiresDepthPrepass, renderPassInputs.requiresNormalsTexture, mainLightShadows, additionalLightShadows);
             }
@@ -677,7 +677,8 @@ public override void Setup(ScriptableRenderContext context, ref RenderingData re
             }
 
             // If a depth texture was created we necessarily need to copy it, otherwise we could have render it to a renderbuffer.
-            if (requiresDepthCopyPass)
+            // Also skip if Deferred+RenderPass as CameraDepthTexture is used and filled by the GBufferPass
+            if (requiresDepthCopyPass && !(this.actualRenderingMode == RenderingMode.Deferred && useRenderPassEnabled))
             {
                 m_CopyDepthPass.Setup(m_ActiveCameraDepthAttachment, m_DepthTexture);
 

com.unity.render-pipelines.universal/Shaders/Utils/CopyDepth.shader

@@ -7,7 +7,7 @@ Shader "Hidden/Universal Render Pipeline/CopyDepth"
         Pass
         {
             Name "CopyDepth"
-            ZTest Always ZWrite On ColorMask 0
+            ZTest Always ZWrite Off ColorMask R
             Cull Off
 
             HLSLPROGRAM

com.unity.render-pipelines.universal/Shaders/Utils/CopyDepthPass.hlsl

@@ -106,7 +106,7 @@ float SampleDepth(float2 uv)
 #endif
 }
 
-float frag(Varyings input) : SV_Depth
+float frag(Varyings input) : SV_Target
 {
     UNITY_SETUP_STEREO_EYE_INDEX_POST_VERTEX(input);
     return SampleDepth(input.uv);