Universal/depth copy as color #5987

jonuuukas · 2021-10-12T10:16:39Z

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

fixing some issues found on staging branch for #5369

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

…f for that

…ted later on)

…be reverted later on)" This reverts commit 80af9be.

… code

… shaders to accommodate that

…rrect one

…r ConfigureTarget

…is handled

…ecals

…t buffer in shader

…g rendering

…for decals

…y-Technologies/Graphics into universal/depth-copy-as-color

github-actions · 2021-10-12T10:16:56Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

github-actions · 2021-10-12T10:17:08Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

…ncorrect depth buffer while on game view

commit 70ad6ee Author: Jonas Sideravičius <jonass@unity3d.com> Date: Thu Oct 14 15:04:53 2021 +0300 adding some editor-specific code to avoid a bug with editor setting incorrect depth buffer while on game view commit 850428a Author: Jonas Sideravičius <jonass@unity3d.com> Date: Wed Oct 13 12:28:57 2021 +0300 null exception fix commit 427e0cb Author: Jonas Sideravičius <jonass@unity3d.com> Date: Wed Oct 13 10:02:30 2021 +0300 another DeferredLights null check commit fcb7d7f Author: Jonas Sideravičius <jonass@unity3d.com> Date: Tue Oct 12 15:31:42 2021 +0300 fix for RTIs non render pass platforms commit 62ca66d Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Oct 12 13:14:55 2021 +0300 fixing shader compilation error and renaming define for fb fetch idx commit b5a042f Merge: 4deded8 f9152cf Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Oct 12 12:11:44 2021 +0300 Merge branch 'universal/depth-copy-as-color' of ssh://github.com/Unity-Technologies/Graphics into universal/depth-copy-as-color commit f9152cf Author: Jonas Sideravičius <jonass@unity3d.com> Date: Tue Oct 12 12:07:03 2021 +0300 adding fb fetch to Gbuffer decals and some other depth related fixes for decals commit 159580e Author: Jonas Sideravičius <jonass@unity3d.com> Date: Mon Oct 11 17:37:35 2021 +0300 fixing DBuffer Decals CopyDepth pass not copying the depth and failing rendering commit f95fafb Merge: c4ddd12 e718a8e Author: Jonas Sideravičius <jonass@unity3d.com> Date: Mon Oct 11 13:45:13 2021 +0300 Merge branch 'master' into universal/depth-copy-as-color commit 4deded8 Merge: c4ddd12 1ede825 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Wed Oct 6 16:30:14 2021 +0300 Merge branch 'master' into universal/depth-copy-as-color commit c4ddd12 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Wed Aug 25 13:40:27 2021 +0300 changing the semantic for outDepthColor in VFXPasses.template commit 5dec840 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Aug 24 11:53:11 2021 +0300 adding depth output for VFXGraph depth only passes commit 2510a18 Merge: fd4df44 a938468 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Mon Aug 23 12:00:52 2021 +0300 Merge branch 'master' into universal/depth-copy-as-color commit fd4df44 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Aug 19 15:47:23 2021 +0300 adding _OUTPUT_DEPTH keyword to CopyDepthPass to select correct output buffer in shader commit 165f4d5 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Aug 17 17:26:19 2021 +0300 some cleanup and refactoring and enabling Renderpass for SS forward decals commit 4f9cbd7 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Aug 17 16:02:04 2021 +0300 adding depth copy for renderpass as well and changing how fake depth is handled commit 68d3938 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Aug 17 10:33:59 2021 +0300 terrain shader passes depthonly pass fix to output clippos commit 399ee75 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Mon Aug 16 16:30:48 2021 +0300 formatting fixes commit ee6e7d4 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Mon Aug 16 11:48:25 2021 +0300 enabling depthbuffer for depth copy and adding additional override for ConfigureTarget commit 6accb1c Author: Jonas Sideravicius <jonass@unity3d.com> Date: Fri Aug 13 16:42:23 2021 +0300 merge fix - change descriptor for DepthOnly configureTarget to the correct one commit d887392 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Fri Aug 13 16:10:30 2021 +0300 fix after updating trunk commit 624f0a1 Merge: 933f089 8ee37d5 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Aug 12 16:53:11 2021 +0300 Merge branch 'master' into universal/depth-copy-as-color commit 933f089 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Aug 12 16:43:25 2021 +0300 making depthOnly pass compatible to render color texture and changing shaders to accommodate that commit c149ec9 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Aug 5 14:40:21 2021 +0300 adding IsTransientAttachment to ScriptableRenderPass/NativeRenderPass code commit d39e96d Author: Jonas Sideravicius <jonass@unity3d.com> Date: Tue Aug 3 11:59:28 2021 +0300 disable fbfetch on DbufferDeferred decals commit d1cef12 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Jul 29 11:57:25 2021 +0300 Revert "some changes to the Foundation Project for Repro project (to be reverted later on)" This reverts commit 80af9be. commit 80af9be Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Jul 29 11:21:14 2021 +0300 some changes to the Foundation Project for Repro project (to be reverted later on) commit a2e4eb6 Author: Jonas Sideravicius <jonass@unity3d.com> Date: Thu Jul 29 11:02:07 2021 +0300 switching _CameraDepthTexture to R32Float and accommodating some stuff for that

phi-lira · 2021-10-22T08:32:44Z

Merged onto staging branch. Staging branch landed onto master on #6085

jonuuukas added 24 commits July 29, 2021 11:02

switching _CameraDepthTexture to R32Float and accommodating some stuf…

a2e4eb6

…f for that

some changes to the Foundation Project for Repro project (to be rever…

80af9be

…ted later on)

Revert "some changes to the Foundation Project for Repro project (to …

d1cef12

…be reverted later on)" This reverts commit 80af9be.

disable fbfetch on DbufferDeferred decals

d39e96d

adding IsTransientAttachment to ScriptableRenderPass/NativeRenderPass…

c149ec9

… code

making depthOnly pass compatible to render color texture and changing…

933f089

… shaders to accommodate that

Merge branch 'master' into universal/depth-copy-as-color

624f0a1

fix after updating trunk

d887392

merge fix - change descriptor for DepthOnly configureTarget to the co…

6accb1c

…rrect one

enabling depthbuffer for depth copy and adding additional override fo…

ee6e7d4

…r ConfigureTarget

formatting fixes

399ee75

terrain shader passes depthonly pass fix to output clippos

68d3938

adding depth copy for renderpass as well and changing how fake depth …

4f9cbd7

…is handled

some cleanup and refactoring and enabling Renderpass for SS forward d…

165f4d5

…ecals

adding _OUTPUT_DEPTH keyword to CopyDepthPass to select correct outpu…

fd4df44

…t buffer in shader

Merge branch 'master' into universal/depth-copy-as-color

2510a18

adding depth output for VFXGraph depth only passes

5dec840

changing the semantic for outDepthColor in VFXPasses.template

c4ddd12

Merge branch 'master' into universal/depth-copy-as-color

4deded8

Merge branch 'master' into universal/depth-copy-as-color

f95fafb

fixing DBuffer Decals CopyDepth pass not copying the depth and failin…

159580e

…g rendering

adding fb fetch to Gbuffer decals and some other depth related fixes …

f9152cf

…for decals

Merge branch 'universal/depth-copy-as-color' of ssh://github.com/Unit…

b5a042f

…y-Technologies/Graphics into universal/depth-copy-as-color

fixing shader compilation error and renaming define for fb fetch idx

62ca66d

jonuuukas requested a review from phi-lira October 12, 2021 10:16

jonuuukas requested review from a team as code owners October 12, 2021 10:16

github-actions bot added SRP testing labels Oct 12, 2021

github-actions bot added universal vfx labels Oct 12, 2021

phi-lira approved these changes Oct 12, 2021

View reviewed changes

jonuuukas added 4 commits October 12, 2021 15:31

fix for RTIs non render pass platforms

fcb7d7f

another DeferredLights null check

427e0cb

null exception fix

850428a

adding some editor-specific code to avoid a bug with editor setting i…

70ad6ee

…ncorrect depth buffer while on game view

phi-lira mentioned this pull request Oct 20, 2021

Universal Staging #6085

Merged

phi-lira closed this Oct 22, 2021

This was referenced Nov 22, 2021

[2021.2][RenderPass] Depth, Normals and Decals fixes #6353

Closed

[2021.2][RenderPass] Depth, Normals, Decals fixes #6354

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Universal/depth copy as color #5987

Universal/depth copy as color #5987

Uh oh!

jonuuukas commented Oct 12, 2021

Uh oh!

github-actions bot commented Oct 12, 2021

Uh oh!

github-actions bot commented Oct 12, 2021

Uh oh!

phi-lira commented Oct 22, 2021

Uh oh!

Uh oh!

Universal/depth copy as color #5987

Universal/depth copy as color #5987

Uh oh!

Conversation

jonuuukas commented Oct 12, 2021

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

github-actions bot commented Oct 12, 2021

Uh oh!

github-actions bot commented Oct 12, 2021

Uh oh!

phi-lira commented Oct 22, 2021

Uh oh!

Uh oh!