Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC721Permit - PermitForAll #271

Merged
merged 12 commits into from
Aug 5, 2024
Merged

ERC721Permit - PermitForAll #271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bd1afc1
initial impl
saucepoint Aug 4, 2024
d2e9425
hashing tests
saucepoint Aug 4, 2024
5d22b1d
setApprovalForAll override tests
saucepoint Aug 4, 2024
0f675cb
reorganize ERC721Permit file
saucepoint Aug 5, 2024
e005016
separate out tests for permit and permitForAll
saucepoint Aug 5, 2024
5cdaba4
tests for permitForAll
saucepoint Aug 5, 2024
3a54c91
regenerate gas
saucepoint Aug 5, 2024
c90e0e9
regenerate gas
saucepoint Aug 5, 2024
4ccc9b7
add to interface
saucepoint Aug 5, 2024
25f2e3a
merge in main; regenerate gas
saucepoint Aug 5, 2024
3a254d0
pr feedback
saucepoint Aug 5, 2024
c9e8c06
rename variable
saucepoint Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
regenerate gas
  • Loading branch information
@saucepoint
saucepoint committed Aug 5, 2024
commit 3a54c91258667b22be8fbbaddd48580669419440
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_empty.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
47158
47176
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_empty_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
46976
46993
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_native_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
122971
122988
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_native_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
122680
122698
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
130049
130067
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129759
129776
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
141357
141379
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_sameRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150205
150227
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150205
150227
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
149830
149852
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
108560
108578
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115748
115770
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115373
115395
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_burnEmpty.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
134128
134146
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_burnEmpty_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126868
126885
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_sameRange_allLiquidity.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
128464
128486
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_take_take.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
116603
116625
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_erc20_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
152311
152333
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_erc20_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
151566
151588
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
134111
134133
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompoundExactUnclaimedFees.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
130350
130372
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompoundExcessFeesCredit.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
170970
170992
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompound_clearExcess.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
140950
140972
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
336789
336811
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_nativeWithSweep_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
345258
345280
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_nativeWithSweep_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
344813
344835
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_onSameTickLower.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
314771
314793
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_onSameTickUpper.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
315413
315435
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_sameRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
240995
241017
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_settleWithBalance_sweep.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
370951
370973
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_warmedPool_differentRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
320789
320811
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
372089
372111
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
371482
371504
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_multicall_initialize_mint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
416464
416530