ERC721Permit - PermitForAll #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Aug 5, 2024
src/base/ERC721Permit_v4.sol
Outdated
| uint256 nonce, | ||
| bytes calldata signature | ||
| ) external payable { | ||
| if (block.timestamp > deadline) revert DeadlineExpired(); |
There was a problem hiding this comment.
shared modifier? We should also make the revert name more distinct since we have DeadlinePassed in modifyLiquidities
snreynolds
reviewed
Aug 5, 2024
src/base/ERC721Permit_v4.sol
Outdated
| ) external payable { | ||
| if (block.timestamp > deadline) revert DeadlineExpired(); | ||
|
|
||
| if (operator == owner) revert NoSelfPermit(); |
There was a problem hiding this comment.
also same? can put this in a shared internal func? same check in permit
src/base/ERC721Permit_v4.sol
Outdated
|
|
||
| if (operator == owner) revert NoSelfPermit(); | ||
|
|
||
| bytes32 hash = ERC721PermitHashLibrary.hashPermitForAll(operator, approved, nonce, deadline); |
There was a problem hiding this comment.
the variable name hash highlights as a keyword for me 🤔
| assertEq(erc721Permit.nonces(alice, wordPos) & (1 << bitPos), 2); // 2 = 0010 | ||
| } | ||
|
|
||
| function test_fuzz_erc721permitForAll_nonceAlreadyUsed() public { |
There was a problem hiding this comment.
this should be fuzzed on the nonce value?
| vm.stopPrank(); | ||
| } | ||
|
|
||
| function test_fuzz_erc721permitForAll_unauthorized() public { |
There was a problem hiding this comment.
also i think this should be _invalidSigner ?
|
|
||
| uint256 nonce = 1; | ||
| uint256 deadline = block.timestamp; | ||
| bytes32 digest = keccak256( |
|
|
||
| uint256 nonce = 1; | ||
| uint256 deadline = block.timestamp; | ||
| bytes32 digest = keccak256( |
| } | ||
|
|
||
| /// @dev a nonce used in permit is unusable for permitForAll | ||
| function test_erc721PermitForAll_permitNonceUsed() public { |
There was a problem hiding this comment.
could probably fuzz this on the nonce value as well ?
snreynolds
reviewed
Aug 5, 2024
src/base/ERC721Permit_v4.sol
Outdated
|
|
||
| if (operator == owner) revert NoSelfPermit(); | ||
| ) external payable checkSignatureDeadline(deadline) { | ||
| _checkNoSelfPermit(owner, operator); | ||
|
|
||
| bytes32 hash = ERC721PermitHashLibrary.hashPermitForAll(operator, approved, nonce, deadline); |
There was a problem hiding this comment.
do u wanna use digest here too?
snreynolds
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #227
Description of changes
Added signature-based
permitForAllfor setting operators (the equivalent to setApprovalForAll)Tested the base contract, and will add another PR for testing with posm operations to try and keep the PR more manageable