This repository was archived by the owner on Apr 25, 2024. It is now read-only.
feat: add support for QuoterV2 #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There's a lot of argument duplication here that makes the diff bigger than it needs to be. It looks like the only real differences in implementation are the argument wrapper and the string function names. Can you make the boolean logic handle only those decisions instead of wrapping duplicate argument constructions as well? |
Contributor
|
Can you also add some tests here that demonstrate usage of the new quoter option? |
JFrankfurt
reviewed
Jul 5, 2022
suggestion for simplifying quoter arg logic
JFrankfurt
reviewed
Jul 6, 2022
NoahZinsmeister
suggested changes
Jul 6, 2022
JFrankfurt
approved these changes
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Uniswap/deploy-v3 (what we used for Celo) deploys the V2 Quoter. Here is the IQuoterV2 interface to see the corresponding structs associated with these changes.