suggestion for simplifying quoter arg logic #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse-Sawa
reviewed
Jul 6, 2022
Comment on lines
+26
to
+40
| interface BaseQuoteParams { | ||
| fee: FeeAmount | ||
| sqrtPriceLimitX96: string | ||
| tokenIn: string | ||
| tokenOut: string | ||
| } | ||
| interface QuoteParamsV1 extends BaseQuoteParams { | ||
| amount?: string | ||
| } | ||
| interface QuoteParamsV2 extends QuoteParamsV1 { | ||
| amountIn?: string | ||
| } | ||
|
|
||
| type QuoteParams = QuoteParamsV1 | QuoteParamsV2 | ||
|
|
Jesse-Sawa
reviewed
Jul 6, 2022
Comment on lines
+71
to
+74
| const quoteV2Params: QuoteParams = { | ||
| amount: quoteAmount, | ||
| fee: route.pools[0].fee, | ||
| sqrtPriceLimitX96: toHex(options?.sqrtPriceLimitX96 ?? 0), |
Owner
There was a problem hiding this comment.
The order of these parameters matter when making the function call.
For QuoterV1, the function argument is an array of values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.