Skip to content

Updated handling of DIBuilder to account for possible dangling ref with GC finalization #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Updated handling of DIBuilder to account for possible dangling ref with GC finalization #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Ubiquity.NET.Llvm/BitcodeModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,12 @@ public void Dispose( )
// finalizer, which would cause an access violation in the native LLVM layer.
if( !IsDisposed )
{
// DI builder is owned by this module, so when it is destroyed so is the builder
if(LazyDiBuilder.IsValueCreated)
{
LazyDiBuilder.Value.BuilderHandle.SetHandleAsInvalid();
}

// remove the module handle from the module cache.
ModuleHandle!.Dispose( );
ModuleHandle = default;
Expand Down
Loading