Skip to content

Updated handling of DIBuilder to account for possible dangling ref with GC finalization #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2021
Merged

Updated handling of DIBuilder to account for possible dangling ref with GC finalization #222

merged 1 commit into from
Nov 28, 2021

Conversation

@smaillet
Copy link
Member

@smaillet smaillet commented Nov 28, 2021 •
edited
Loading

Fixes #221

  • In Dispose of BitCodeModule, Marked DIBuilder, if created, as invalid
  • Added checks to DiBuilder members to throw if the handle is invalid

@cibuild-telliam
In dispose of BitCodeModule, Marked DIBuilder, if created, as invalid…
94da6d4 
…. Added checks to DiBuilder members to throw if the handle is invalid
@smaillet smaillet merged commit 54789d0 into UbiquityDotNET:develop Nov 28, 2021
@smaillet smaillet deleted the fixbuildbreak branch May 4, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] - [Build break] Official build on Develop failed

2 participants

@smaillet @cibuild-telliam