-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qc-iot): add features for quezon city IoT #286
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added github actions workflow for auto deployment to both s3 and asti servers
Changed to staging. Created branch for staging.
# Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo ![Kapture 2021-10-05 at 22 49 45](https://user-images.githubusercontent.com/11599005/136047077-d0da7a85-9157-4d01-bae9-07a6039fd9c1.gif)
* Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography.
* Added AWS deployment workflow
…into feat/qc-sensors
4 tasks
* feat(qc-iot): get all sensor latest data and chart for rain (acc) * added label for flood and rain, in services deleted link for testing link * added label for mobile view in dashboard summary * deleted unused code * changed UI for summary dashboard, fixed pagination, hover sensor popup status, create status column * changed UI for header dashboard summary * change sort display * changed base URL for qc * remove plotbands in rain graph * responsive modal for summary dashboard and sorting unavailable data to last item * fixed header sort * fixed mobile view Co-authored-by: bon-carpo <jccarpo@up.edu.ph>
* feat/qc-iot: press enter to login * sidebar IOT changed to IoT * Pop up alert and deleted qc-login component * added noah login loading
* feat/qc-iot: press enter to login * sidebar IOT changed to IoT * Pop up alert and deleted qc-login component * change router link * add qc login component * change url link * modal login in noah studio and alert, and logout yes or no choices * cleaning of code, deleted unused codes * alert login and logout revised UI * change button for alert Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com>
* change text in IoT and show by default government facilities * change summary dashboard ui * mobile view * change name of sensor type
* qc iot display all data * KYH legend and noah studio display text latest data * bigger text font for latest_data * added overflow (scroll) in summary data table * KYH UI legend from column to row * change endpoint qc and also for summary dashboard sensor count active * table header fixed when scroll * API removed unit for latest_data from BE, display unit together with the latest_data
* add quezon city muni boundary * update noah-playground-store to contain quezon city muni boundary state * update playground service to accommodate qc muni boundary setters and getters * add qc muni boundary in qc group and ui display * display and set properties for qc muni boundary in map * delete unused lines * add qc muni boundary legend * edit css
* change default lat lng for qc * change text IoT in sensor mouseover
bon-carpo
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Ready to merge
* hovering IoT sensor and still open the popup chart * hide hover while unchecked iot sidebar
* change default lat lng for qc * change text IoT in sensor mouseover * change qc boundary legend
* Iot Graph after QA * qa graph iot
* change default lat lng for qc * change text IoT in sensor mouseover * change qc boundary legend * change title for rain gauge
* Iot Graph after QA * qa graph iot * 2 decimal places when hovering chart * insert try catch to load data
* edited some problem in IoT * display level for rain dashed and edited UI for mobile view * level HIGH changed
* fix(kyh): add debris flow in assessment in know your hazard page (#316) * remove 24hour lapse contour * add debris flow for assessment in kyh * add other layers for lh2 in kyh combined layers * add condition in debris flow * adjust comment * feat(kyh): add draggable marker location for new assessments (#319) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo ![Kapture 2021-10-05 at 22 49 45](https://user-images.githubusercontent.com/11599005/136047077-d0da7a85-9157-4d01-bae9-07a6039fd9c1.gif) * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * KYH: draggable marker with assessment and display location --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * WIP(KYH): added tip for draggable and kyh legend (#321) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo ![Kapture 2021-10-05 at 22 49 45](https://user-images.githubusercontent.com/11599005/136047077-d0da7a85-9157-4d01-bae9-07a6039fd9c1.gif) * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * WIP: tip for dragging marker and KYH legend --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * fix(noah-studio): change default color for hazard layers (#323) * remove 24hour lapse contour * change default color for hazard layers * change mail to address * add space in mail to * add rain data per hour * edit text --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com> Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes: