feat(kyh): added tip for draggable and kyh legend #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added github actions workflow for auto deployment to both s3 and asti servers
Changed to staging. Created branch for staging.
# Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo 
* Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography.
* Added AWS deployment workflow
✅ Deploy Preview for noah-ph ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bon-carpo
approved these changes
Mar 15, 2023
kennethliporada
changed the title
kennethliporada
changed the title
bon-carpo
added a commit
that referenced
this pull request
May 29, 2023
* fix(kyh): add debris flow in assessment in know your hazard page (#316) * remove 24hour lapse contour * add debris flow for assessment in kyh * add other layers for lh2 in kyh combined layers * add condition in debris flow * adjust comment * feat(kyh): add draggable marker location for new assessments (#319) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo  * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * KYH: draggable marker with assessment and display location --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * WIP(KYH): added tip for draggable and kyh legend (#321) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo  * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * WIP: tip for dragging marker and KYH legend --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * fix(noah-studio): change default color for hazard layers (#323) * remove 24hour lapse contour * change default color for hazard layers * change mail to address * add space in mail to * add rain data per hour * edit text --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com> Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com>
bon-carpo
added a commit
that referenced
this pull request
Aug 9, 2023
…331) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo  * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * update noah-playground-store to contain qc sensor state * update playground service to accommodate qc sensors setters and getters * add group and solo component and listen to state * change tab menu to IoT Sensors * package-lock * separate weather sensor to flood sensor * add services for iot qc * add login component in shared file * add login button in navigation * feat(qc-iot): update IOT sensors tab and IOT graph (#274) * update noah-playground-store to contain qc sensor state * update playground service to accommodate qc sensors setters and getters * add group and solo component and listen to state * change tab menu to IoT Sensors * separate weather sensor to flood sensor * add services for iot qc * FEAT: IOT Sensors Tab: change options to checkbox, changed naming for options for IOT, IOT legend Colors * default flood sensor once IoT sensor clicked * added burger menu for download image and csv * fix css for X button upper right side of the chart * Close button size in chart * fix close button for iot chart * base url changed for IoT * (1)base url changed for IoT * Deleted unused code and comments * changed base url for IoT Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> Co-authored-by: bon.carpo <jccarpo@up.edu.ph> * add login modal * add auth in login service * add base url * added validation for username and password * add router link * feat(qc-studio): Graph/Chart with Calendar module * WIP:(Iot) - Disclaimer Modal * WIP: Modal for disclaimer and summary: view summary getting location name in API * hide summary dashboard if iot sensors is not shown * summary dashboard display location * login new base url * WIP: QC Login user and logout and also show name and Image * WIP: logged in and flyto to noah studio and checked iot sidebar * feat(qc-studio): Graph/Chart with Calendar module (#276) * feat(qc-studio): Graph/Chart with Calendar module * WIP:(Iot) - Disclaimer Modal * WIP: Modal for disclaimer and summary: view summary getting location name in API * WIP: date and time change to whole number * WIP: IoT calendar data and sidebar name * WIP: disclaimer modal with content * WIP: IoT calendar with pointInterval 5 mins] * WIP: calendar working (finally) Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * show summary dashboard on IOT click * WIP: QC Logged in Flyto and disclaimer * noah loading screen and expiration when logged in * Login show if you directly type in url * add sample data * update package lick * add sort and search in summary * separate QC url for login * example for hide and show qc and login with diff url for qc and normal login noah * get data from API * search and size of modal summary * UX for modal summary * WIP: displaying iot data summary from api * IoT summary data modal from api with loading * IoT summary data modal from api with loading(1) * IoT summary data modal from api with loading(2) with clean code * IoT summary data modal from api with loading(3) with clean code * responsive table data summary * merge to main and fix zoom in to qc on login * fixed latest date and time display * add govt qc fac sidebar * add qc critical facilities component * change name for qc sensor type * show qc crit fac in sidebar onclick of iot * show/hide qc critical facilities in IOT * sorting for web browser and click header table for sort * add qc crit fac legend color * iot data summary with sorting web and mobile * refactor qc-login with noah loading screen * IoT Summary data pagination * display legend color * disclaimer responsive * feat(qc-iot): additional features/enhancement for qc iot (#287) * feat(qc-iot): zoom to qc when clicked iot sidebar, removed unnecessary codes * feat(qc-iot): for demo * feat(qc-iot): for demo(1) * for demo * fixed disclaimer and deleted comments and none functions code * feat: dashboard critical level colors and id for sensor click * Refactor: Deleted unused codes like comments; disclaimer (things) * feat: UI for Rainfall, button and sensor color and auto refresh view data summary * display and filter qc iot rain and flood in map * feat: iot graph colors and rainfall, fixed bug for auto refresh * fix conflicts * feat: IoT graph label Meters (M) and console error observable fixed * Feat: alert if no data summary fetch Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> Co-authored-by: bon-carpo <jccarpo@up.edu.ph> * merge to main * feat(qc-iot): add tab navigation for different type in summary dashboard (#292) * feat: tab navigation for sensors and button color active * feat: IoT graph sensor hover label for flood. * feat: Refactor codes and erased slashed (/) when hover a graph. * changed QC Base URL Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * feat(qc-iot): summary dashboard label and rain value and mobile view (#294) * feat(qc-iot): get all sensor latest data and chart for rain (acc) * added label for flood and rain, in services deleted link for testing link * added label for mobile view in dashboard summary * deleted unused code * feat(qc-iot): change UI for dashboard summary and update graph/chart (#295) * feat(qc-iot): get all sensor latest data and chart for rain (acc) * added label for flood and rain, in services deleted link for testing link * added label for mobile view in dashboard summary * deleted unused code * changed UI for summary dashboard, fixed pagination, hover sensor popup status, create status column * changed UI for header dashboard summary * change sort display * changed base URL for qc * remove plotbands in rain graph Co-authored-by: bon-carpo <jccarpo@up.edu.ph> * feat(qc-iot): summary dashboard UI and mobile view (#296) * feat(qc-iot): get all sensor latest data and chart for rain (acc) * added label for flood and rain, in services deleted link for testing link * added label for mobile view in dashboard summary * deleted unused code * changed UI for summary dashboard, fixed pagination, hover sensor popup status, create status column * changed UI for header dashboard summary * change sort display * changed base URL for qc * remove plotbands in rain graph * responsive modal for summary dashboard and sorting unavailable data to last item * fixed header sort * fixed mobile view Co-authored-by: bon-carpo <jccarpo@up.edu.ph> * feat(qc-iot): loading for noah login (#297) * feat/qc-iot: press enter to login * sidebar IOT changed to IoT * Pop up alert and deleted qc-login component * added noah login loading * feat(qc-iot): qc login in noah studio (#298) * feat/qc-iot: press enter to login * sidebar IOT changed to IoT * Pop up alert and deleted qc-login component * change router link * add qc login component * change url link * modal login in noah studio and alert, and logout yes or no choices * cleaning of code, deleted unused codes * alert login and logout revised UI * change button for alert Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com> * feat(qc-iot): display all data by default in graph (#300) * fix(qc-studio): fix ui for summary dashboard and name sensor type (#301) * change text in IoT and show by default government facilities * change summary dashboard ui * mobile view * change name of sensor type * feat(qc-iot): added unit for iot dot, KYH legend (#303) * qc iot display all data * KYH legend and noah studio display text latest data * bigger text font for latest_data * added overflow (scroll) in summary data table * KYH UI legend from column to row * change endpoint qc and also for summary dashboard sensor count active * table header fixed when scroll * API removed unit for latest_data from BE, display unit together with the latest_data * feat(kyh): update kyh legend (#304) * feat(qc-iot): add Quezon City Municipal boundary (#302) * add quezon city muni boundary * update noah-playground-store to contain quezon city muni boundary state * update playground service to accommodate qc muni boundary setters and getters * add qc muni boundary in qc group and ui display * display and set properties for qc muni boundary in map * delete unused lines * add qc muni boundary legend * edit css * chart default to all (#305) * fix(qc-iot): fix bugs from QA (#306) * change default lat lng for qc * change text IoT in sensor mouseover * hovering IoT sensor and still open the popup chart (#308) * fix(qc-iot-qa): when IoT sidebar unchecked hide popup (#310) * hovering IoT sensor and still open the popup chart * hide hover while unchecked iot sidebar * fix(qc-iot): change QC boundary legend (#309) * change default lat lng for qc * change text IoT in sensor mouseover * change qc boundary legend * feat(qc-iot): qa chart IoT graph (#311) * Iot Graph after QA * qa graph iot * fix(qc-iot): change rain gauge title in summary dashboard (#312) * change default lat lng for qc * change text IoT in sensor mouseover * change qc boundary legend * change title for rain gauge * add flood legend in graph * feat(qc-iot): hovering chart value in 2 decimal places (#313) * Iot Graph after QA * qa graph iot * 2 decimal places when hovering chart * insert try catch to load data * feat(qc-iot): showing battery level hover points (#314) * remove kyh legend in kyh page (#322) * feat: UI for multiple municipal in IoT project * added laguna sensor solo * spacing of title and add disclaimer * showing all sensor for qc and laguna * IoT Sensor name font size bigger * determine whos account login and cant download but the there is something missing in feature that no error alert for download when qc logged in * font size text for hover graph * changed the size of the graph for iot * fix(qc-iot): QC IoT summary dashboard ui and mobile view (#326) * edited some problem in IoT * display level for rain dashed and edited UI for mobile view * level HIGH changed * fix(qc-iot): add accumulated data for rain per hour (#329) * fix(kyh): add debris flow in assessment in know your hazard page (#316) * remove 24hour lapse contour * add debris flow for assessment in kyh * add other layers for lh2 in kyh combined layers * add condition in debris flow * adjust comment * feat(kyh): add draggable marker location for new assessments (#319) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo  * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * KYH: draggable marker with assessment and display location --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * WIP(KYH): added tip for draggable and kyh legend (#321) * Added github actions workflow for aut deployment to .72 server. * Added github action for S3 deployment. * Changed to staging. Created branch for staging. * Retrigger deployment workflow. * fix(studio): zoom in on ios (#192) # Summary - Fixes #186 - The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once. - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH - Confirming that only the NOAH Studio is affected by this issue. # Demo  * ci(netlify): add _redirects file * S3 Deployment Validation (#198) * Added if condition to run workflow only on successful PR merge. (#195) * Checking proper automation workflow. Will revert this small change upon validation. (#196) * Change deployment trigger. Revert small biblio change. (#199) * Checking proper automation workflow. Will revert this small change upon validation. * Changed trigger for deployment workflow. Revert small change to bibliography. * Cascade dev changes on workflow to prod (#202) * Added AWS deployment workflow * WIP: tip for dragging marker and KYH legend --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * fix(noah-studio): change default color for hazard layers (#323) * remove 24hour lapse contour * change default color for hazard layers * change mail to address * add space in mail to * add rain data per hour * edit text --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com> Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> * table level for dashboard with qc and laguna sensor * added sta cruz laguna to dashboard * summary dashboard update * add disclaimer for iot sensors * condition in download files and text in graph * remove day grouping * edit flood label text in graph * fix bug in computation for total sensor, active and inactive in summary dashboard * fix condition if someone logged in and download data * fix condition if user login in noah studio and stop popup when already logged in * fix(iot): fix bugs for qc and laguna iot combination (#332) * fix bug in computation for total sensor, active and inactive in summary dashboard * fix condition if someone logged in and download data * fix condition if user login in noah studio and stop popup when already logged in * change rain latest data in summary * change high level text in graph * change source link for qc and laguna logo * fix condition for popup when someone already logged in and login modal for different municipality * Fixed loading chart and after load the graph default for 1 day selector * edited zoom default * fix(iot): fix bug and errors in login modal ang graph display (#333) * fix bug in computation for total sensor, active and inactive in summary dashboard * fix condition if someone logged in and download data * fix condition if user login in noah studio and stop popup when already logged in * fix condition for popup when someone already logged in and login modal for different municipality * Fixed loading chart and after load the graph default for 1 day selector * edited zoom default * add banner for sta cruz * added label for graph rain sensor * sensor circle size depending on zoom level (#334) * fix(qc-iot): add latest data in popup map display (#336) * add latest data in popup * chore(release): v2.0.0 and v3.0.0 update CHANGELOG.md --------- Co-authored-by: pfgoting <pfgoting@gmail.com> Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com> Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com> Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots