-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/1815 removed unused audits amend #679
Open
jenbutongit
wants to merge
29
commits into
master
Choose a base branch
from
chore/1815-removed-unused-audits-amend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBray
reviewed
Sep 28, 2023
...nnual-review/scheduler/the_reminder_email_for_string_weeks_is_sent_to_eligiable_providers.js
Outdated
Show resolved
Hide resolved
RichardBray
reviewed
Sep 28, 2023
src/scheduler/workers/processListsBeforeAndDuringStart/helpers.ts
Outdated
Show resolved
Hide resolved
jenbutongit
force-pushed
the
chore/1815-removed-unused-audits-amend
branch
from
September 29, 2023 10:48
5d17681
to
8c2bf75
Compare
Squashed commits: [f21dd86] docs, tidy [c25983e] add composeKeyDatesForDate tests [4957b51] add eventName: "startAnnualReview" and fix tests [351d3d1] check oneDayBeforeUnpublish [047ab92] lint [a119939] also insert annual review data into audit. [4ce950f] tidying [10e57ce] fixing tests [89bc9cf] fix: use getNotifyClient for sendUnpublishReminder. Change query to look for `weeklyUnpublish` [0c4474a] fix test [3886463] do not record video [6a5f159] fix lint [7e83b12] return [efe56d0] tiding [1751542] video: true [692bde8] debug [2e23ffa] return [6c9506f] tidy [488cdc6] refactor: tidy processListsBeforeAndDuringStart [d59f2ee] fix smoke test query [4d3c364] fix migration [33a1ef6] tidy [bd1b07b] order by time desc [d2024ce] docs, tidy [47582a1] fix tests [c90f6c2] tidy comment [280f21c] tidy [fc79284] lint [cf9bf90] remove unused types [76f9cfa] tidy types [225c978] tidy [1016f20] add reference param [4ba68a0] tidying [721f12e] refactor: use type from prisma client. [75f137a] refactor: use ListAnnualReviewPostReminderType for sendAnnualReviewPostEmails [6f4688f] migration [0fc9081] clean up [b93d915] simplifying annualReviewProviderType enums [db83234] change send**postEmail to just name of the email. change order of enums [d636907] shouldSend logs and docs [52b7d7f] change emailType to annualReviewEmailType [04762cf] migrations [289005a] chore(ingestPutController.ts): fix import path for EventCreate type from "server/models/listItem/listItemEvent" to "shared/listItemEvent" to resolve import error [63ae40c] chore(listItemEvent.ts): refactor the [ListItemEvent.EDITED] event creation function to accept additional options for different types of edits [53e947d] chore(worker.feature): update scenario names to be more descriptive chore(the_string_key_date_email_will_be_sent_to_post.js): simplify the where clause in the query to improve readability and maintainability [8f2d179] chore: add emailType to prisma queries [eb7f672] chore(migration.sql): add migration script to add emailType columns to Audit and Event tables chore(schema.prisma): add emailType fields to Audit and Event models [ea961bc] chore: fix issues with unit tests [1a998c7] chore: address issues raised in PR [f603ecb] chore(migration.sql): delete unused audits for list items [2068e78] chore(migration.sql): update migration to delete only listItem audits with auditEvent set to 'REMINDER' refactor(listItemEvent.ts): remove unnecessary check for "id" in response [3097a16] chore(migration.sql): Remove unused enum values from `AuditEvent` enum [1dd6326] chore(migrations): add migration to delete unused audits and update audit enum chore(migrations): add migration to delete unused audits chore(migrations): add migration to update audit enum [25e066d] chore: include start of annual review date when getting reminder events refactor: rename function names that didn't make sense [2bb242d] chore: fix issue with failing smoke test by... chore(an_email_for_the_string_key_date_is_sent_to_eligible_providers.js): add array to test instead of string chore(audit.ts): add missing export statement for findReminderAuditEvents function chore(govukNotify.ts): update return value of sendAnnualReviewProviderEmail and sendAnnualReviewPostEmail functions chore(helpers.ts): update parameter type of isEmailSentBefore function chore(main.ts): update import statements for Audit and Event types [53c0ad0] chore: fix issue with smoke test failing [9316919] chore(resetAnnualReviewForList.ts): uncomment code to add audit event for endAnnualReview [ef22446] chore: fix type related issues [a42e5e5] chore(types.ts): remove NotifyResult interface chore(govuk-notify.ts): change return value of sendAuthenticationEmail, sendApplicationConfirmationEmail, sendDataPublishedEmail, and sendEditDetailsEmail to check for "id" in result and result.id !== undefined chore(notifications-node-client.ts): change statusText to id in mockResolvedValue [1969ccc] refactor: remove depreciated recordListItemEvent function and all references to it [76272f2] change funeral director to lawyer [0105e4e] remove button import [75781a4] mimic apply footer [6b5f40e] smoke tests [cc36e82] skip if /session/* route [2cd89f7] replay answer [472d5b3] fix smoke tests [ca7dfce] e2e tests [463e0c4] add backLinkFallback [e362daf] chore: fix issues with unit tests [31b0424] chore: fix issues with cookies not working [91212a9] chore(proxyMiddleware): add lawyersPostController to handle POST request for /application/lawyers/which-list-of-lawyers route chore(proxyMiddleware): update route handlers in applyRouter to use lawyersPostController instead of postLawyers chore(listItemCreateInputFromWebhook): update countryName parameter to use addressCountry property from deserialised data [d9895c1] add back pro-bono skip for prt [eebe79d] refactor(express-session.ts): add application object to SessionData interface to store application related data refactor(applyController.ts): add postLawyers function to handle POST request for lawyers application [ed587ab] add back can you offer pro-bono services to british nationals [e58541c] fix logic [f897fbf] allow /application/session routes to pass through without country check [e1d3d9b] remove unused [1f8320c] tidy [5dec6af] wip [1f6de9f] wip [5a61d06] feat: move "which list of lawyers do you want to be added to" into lists so we can serve the "We are not currently accepting online applications" page dynamically
jenbutongit
force-pushed
the
chore/1815-removed-unused-audits-amend
branch
from
September 29, 2023 11:00
8c2bf75
to
774679a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor/cleanup
Previously, events were being recorded in two places, in the Event table and the Audit table. This change makes the approach more consistent. events which relate to
ListItem
s will be recorded on theEvent
table, and other events will be recorded on theAudit
table.A new nullable column has been added to both
Event
andAudit
-annualReviewEmailType
which are enums. This will help with querying the different types of email types, where previously the approach was inconsistent between tables.For Audit, you may search for these annual review emails:
For ListItem, you may search for these annual review emails:
When annual review data is generated,
List.jsonData.currentAnnualReview
, it is now also added to the theAudit
table. After an annual review ends, it is now easier to aggregate annual review Audits and Events.