chore(migration.sql): update migration to delete only listItem audits…

… with auditEvent set to 'REMINDER' refactor(listItemEvent.ts): remove unnecessary check for "id" in response
UKForeignOffice · Aug 16, 2023 · 2068e78 · 2068e78
1 parent 3097a16
commit 2068e78
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/server/models/db/migrations/20230717140537_delete_unused_audits/migration.sql b/src/server/models/db/migrations/20230717140537_delete_unused_audits/migration.sql
@@ -1,3 +1,3 @@
 -- Delete all lstItem audit events.
 DELETE FROM "Audit"
-WHERE type = 'listItem';
+WHERE type = 'listItem' AND "auditEvent" = 'REMINDER';
diff --git a/src/shared/listItemEvent.ts b/src/shared/listItemEvent.ts
@@ -123,12 +123,10 @@ export const EVENTS = {
   }),
 
   [ListItemEvent.REMINDER]: (
-    response: SendEmailResponse | {},
+    response: SendEmailResponse,
     notes?: string[],
     reference?: string
-  ): EventCreate<"REMINDER"> | undefined => {
-    if (!("id" in response)) return;
-
+  ): EventCreate<"REMINDER"> => {
     const notifyResponseWithoutContent = {
       id: response.id,
       template: response.template,