Fix broken core snapshot tests #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated snapshot path handling so that both snapshot assertion functions work correctly when tests are run using absolute paths. The directory path is now derived without a prefixed “./”
Chemaclass
force-pushed
the
fix/447-assert-snapshot
branch
from
7fd1d15 to
9cc65bf
Compare
Contributor
|
The issue in Nix is fixed ! https://gist.github.com/drupol/3723f5a4ba4d53f460ee72b793ba0727 |
Contributor
|
However, the new CI workflow is useless, sadly... it's a bit of a waste of resources too to keep it there. |
Member
Author
|
@drupol do you mean this one? https://github.com/TypedDevs/bashunit/pull/452/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR122 I was thinking how could we make sure to avoid problems for NixOS future. But if you say it is using ubuntu and it is not needed, then we can remove it, no problemo:
|
Chemaclass
added a commit
that referenced
this pull request
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Related: #447
🔖 Changes
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix