Failing tests on 0.22.0

[drupol]

Hello,

Q	A
OS	NixOS
Shell & version	bash 3.2
bashunit version	0.22.0

Summary

Today I tried to provide an update of Bashunit in Nix and while making the update (follow the PR at NixOS/nixpkgs#427198), I noticed that 2 core tests are broken.

      >
       > Running tests/unit/test_doubles_test.sh
       > ✓ Passed: Successful mock                                                                18.818 ms
       > ✓ Passed: Successful override ps with echo with mock                                    16.3423 ms
       > ✓ Passed: Successful spy                                                                35.4721 ms
       > ✓ Passed: Unsuccessful spy called                                                       31.5284 ms
       > ✓ Passed: Successful spy called times                                                   30.3163 ms
       > ✓ Passed: Unsuccessful spy called times                                                 36.0456 ms
       > ✓ Passed: Successful spy with source function                                           38.8206 ms
       > ✓ Passed: Unsuccessful spy with source function have been called                        50.1873 ms
       > ✓ Passed: Successful spy called times with source                                        34.303 ms
       > ✓ Passed: Spy called in subshell                                                         55.583 ms
       > ✓ Passed: Mock called in subshell                                                        33.441 ms
       > ✓ Passed: Spy called with different arguments                                           80.8192 ms
       > ✓ Passed: Spy successful not called                                                     65.9594 ms
       > ✓ Passed: Spy unsuccessful not called                                                   77.5631 ms
       >
       > There were 2 failures:
       >
       > |1) tests/unit/assert_snapshot_test.sh
       > |✗ Failed: Assert match snapshot with placeholder
       > |    Expected 'to be empty'
       > |    but got  '✗ Failed: Assert match snapshot with placeholder
       > |    Expected to match the snapshot'
       > |2) tests/unit/assert_snapshot_test.sh
       > |✗ Failed: Assert match snapshot with custom placeholder
       > |    Expected 'to be empty'
       > |    but got  '✗ Failed: Assert match snapshot with custom placeholder
       > |    Expected to match the snapshot'
       >
       > Tests:      366 passed, 11 skipped, 7 incomplete, 2 snapshot, 2 failed, 388 total
       > Assertions: 510 passed, 11 skipped, 8 incomplete, 2 snapshot, 2 failed, 533 total
       >
       >  Some tests failed 
       > Time taken: 42 s
       > make: *** [Makefile:64: test] Error 1
       For full logs, run:
         nix log /nix/store/qvb0c3sckwqdcpjjhvais1gfv05bfxp4-bashunit-0.22.0.drv

Current behavior

The tests should pass.

How to reproduce

I guess the issue in only while trying to run the tests in isolated and immutable environment where it is not possible to create files or directories in the source folder. Using a temporary directory in the test might fix the issue.

[drupol]

I created a PR fixing the issue at #448 and included the patch in the Nix expression, tests are now passing as you can see in NixOS/nixpkgs#427198

[drupol]

Sadly I got the same issue in 0.22.1. I will check in the evening... gotta work now :(

[Chemaclass]

@drupol hopefully this will help #452

[drupol]

Hey!

The new ci workflow is not needed, it's running on Ubuntu :)

It is broken in nix because while building the final shell script, the tests are trying to write somewhere they should not (isolation process). Trying to run the final shell script in bash provided by nix does not help finding if the tests are running.

I will tests this branch soon and let you know if it fixes the issue.

[Chemaclass]

@drupol please try the new release https://github.com/TypedDevs/bashunit/releases/tag/0.22.2