Skip to content

Conversation

@Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Oct 5, 2024

📚 Description

Follow up after: #350

Idea by @skinner-m-c -> #350 (comment)

🔖 Changes

  • Improve assert_true and assert_false
    • Consider passing a function/command/alias that will resolve into true or false

🖼️ Screenshots

Screenshot 2024-10-06 at 11 18 58 Screenshot 2024-10-06 at 11 19 07

check the exit_code for commands/functions as well
check the exit_code for commands/functions as well
@Chemaclass Chemaclass added the enhancement New feature or request label Oct 5, 2024
@Chemaclass Chemaclass self-assigned this Oct 5, 2024
@Chemaclass Chemaclass mentioned this pull request Oct 5, 2024
2 tasks
@Chemaclass Chemaclass changed the title Improve assert true Improve assert true/false accepting callable as arg Oct 5, 2024
@Chemaclass Chemaclass force-pushed the feat/improve-assert-true branch 2 times, most recently from 9a94f17 to ad7772a Compare October 6, 2024 00:04
@Chemaclass Chemaclass force-pushed the feat/improve-assert-true branch from ad7772a to 5967dd6 Compare October 6, 2024 00:08
@Chemaclass Chemaclass force-pushed the feat/improve-assert-true branch from bd339c0 to 7850182 Compare October 6, 2024 09:17
@Chemaclass Chemaclass merged commit 1350921 into main Oct 6, 2024
@Chemaclass Chemaclass deleted the feat/improve-assert-true branch October 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants