Add assert_true and assert_false #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusValeraDev
approved these changes
Oct 4, 2024
2 tasks
skinner-m-c
reviewed
Oct 5, 2024
Contributor
skinner-m-c
left a comment
skinner-m-c
left a comment
There was a problem hiding this comment.
Thanks for adding true and false assertions.
| local actual="$1" | ||
|
|
||
| if [[ "$actual" != "false" && "$actual" != "1" ]]; then | ||
| local label |
Contributor
There was a problem hiding this comment.
[nit] Note that this does not seem to work on functions. If I pass assert_true ls the assertion fails. A potential problem may be that the concept of true and false as used in if statements does not apply with this assertion. If statements really just match the exit code of the expression. Bash makes use of the test program to perform much of the boolean logic in BASH, which has the [[ ... ]] shorthand.
Future work might want to test if the value passed is a function (type -f <var>) or a value and do something. different.
Member
Author
There was a problem hiding this comment.
I will work on this, many thanks!! | UPDATE: #352
Chemaclass
added a commit
that referenced
this pull request
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔖 Changes
assert_trueassert_false✅ To-do list
CHANGELOG.mdto reflect the new feature or fix