Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve generation of diagnostics, fix linter tests #268

Merged
merged 4 commits into from
Apr 23, 2019
Merged

improve generation of diagnostics, fix linter tests #268

merged 4 commits into from
Apr 23, 2019

Commits on Apr 22, 2019

  1. fix(tests): linter tests - useTypescriptIncrementalApi usage 

    actually use the correct `useTypescriptIncrementalApi` value for some of the linter tests that were using the default value before
    @phryneas
    phryneas committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    e0020d6 View commit details
    Browse the repository at this point in the history

  2. fix(tests): fix linter tests that were doing nothing 

    fix a bug where, as `tslint` was set to true and the files being checked had no parent folder with a tslint.json, tslint in these tests never found any warnings
also fixes a failing test because a syntactic error was counted as linter warning
    @phryneas
    phryneas committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    d078278 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. feat(apiincrementalchecker): improve generation of diagnostics 

    when the options `checkSyntacticErrors: false` and `useTypescriptIncrementalApi: true` both were active, no semantic errors were emitted as soon as the first syntactic error was encountered
this patches the `typescript` import to override that behavior

see discussion in TypeStrong#257
    @phryneas
    phryneas committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    ae80e5f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'beta' into fix-linter-tests

    @phryneas
    phryneas authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    9b73b3a View commit details
    Browse the repository at this point in the history