improve generation of diagnostics, fix linter tests #268
Conversation
phryneas
force-pushed
the
fix-linter-tests
branch
from
b1d57a7
to
59247b7
Compare
|
(just force-pushed everything because I had the wording of the commit messages wrong 😁 ) |
|
I'm afraid you are missing colon next to the |
Whoops! Will do a rebase & rename :) |
phryneas
force-pushed
the
fix-linter-tests
branch
from
59247b7
to
ab0f586
Compare
phryneas
force-pushed
the
fix-linter-tests
branch
from
ab0f586
to
2709397
Compare
|
Okay, I'll rebase this on the current |
actually use the correct `useTypescriptIncrementalApi` value for some of the linter tests that were using the default value before
fix a bug where, as `tslint` was set to true and the files being checked had no parent folder with a tslint.json, tslint in these tests never found any warnings also fixes a failing test because a syntactic error was counted as linter warning
phryneas
force-pushed
the
fix-linter-tests
branch
from
2709397
to
17d7440
Compare
|
@piotr-oles @johnnyreilly Oh, seeing that I can now merge PRs myself: what is my mode of operation here? Wait for one of you two to approve the changes, then merge into |
|
For me one approve is enough for fixes and small improvements :) For breaking changes and new features I think it will be better for all of us to get review from two different developers :) |
That's a sensible general approach I think. 👍 The flip side of that is that it's important that reviews happen in a timely fashion. So if someone has asked me for a review and I haven't come back to them in a reasonable period of time, they should feel free to keep shipping.😁🛳️ BTW feel free to merge this when you've added the comment I requested @phryneas! |
when the options `checkSyntacticErrors: false` and `useTypescriptIncrementalApi: true` both were active, no semantic errors were emitted as soon as the first syntactic error was encountered this patches the `typescript` import to override that behavior see discussion in TypeStrong#257
phryneas
force-pushed
the
fix-linter-tests
branch
from
17d7440
to
ae80e5f
Compare
phryneas
dismissed
johnnyreilly’s stale review
guess I have to dismiss this to be able to merge? sorry -.-
|
🎉 This PR is included in version 1.2.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This is great work @phryneas! @piotr-oles what's the process now? We raise a PR to merge from |
|
🎉 This PR is included in version 1.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
(feat) improve generation of diagnostics
(fix) linter tests
(fix) linter tests that were doing nothing
see discussion in #257
this is based off #253, so please merge that before you merge this :) (should also make the diff more readable)