Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev-script failing in windows issue #969

Closed
wants to merge 2 commits into from

Conversation

rogueloop
Copy link

@rogueloop rogueloop commented Jul 29, 2024

/claim #955
close #955

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jul 30, 2024 6:44pm

Copy link

vercel bot commented Jul 29, 2024

Someone is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@zaaakher
Copy link
Contributor

zaaakher commented Jul 30, 2024

I just tested it on both Windows 10 and MacOS and here are the current results

OS Updates examples.gen.tsx Generates example files
Windows
MacOS

By "Generates example files" I mean the package.json, tsconfig.json, index.html, main.tsx, and vite.config.ts in each example folder that should be automatically generated by the script.

Note: I copied the above text from my response to the other PR about the same issue because it's actually the same case scenario.

@rogueloop
Copy link
Author

gen.ts.-.BlockNote.-.Visual.Studio.Code.2024-07-31.00-12-27.mp4

Addressed the issues @zaaakher

@zaaakher
Copy link
Contributor

zaaakher commented Jul 30, 2024

@rogueloop I just tested again and it's working well just as expected 👍

OS Updates examples.gen.tsx Generates example files
Windows
MacOS

@rogueloop
Copy link
Author

rogueloop commented Jul 31, 2024

Ready for a review @YousefED

@rogueloop rogueloop closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev-scripts path issue on Windows
2 participants