Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-scripts path issue on Windows #955

Closed
1 task
zaaakher opened this issue Jul 19, 2024 · 11 comments · Fixed by #970
Closed
1 task

dev-scripts path issue on Windows #955

zaaakher opened this issue Jul 19, 2024 · 11 comments · Fixed by #970
Labels
💎 Bounty bug Something isn't working 💰 Rewarded

Comments

@zaaakher
Copy link
Contributor

Describe the bug
Running npm run gen throws the following error on Windows:

image

To Reproduce

  • Be on Windows 10
  • Run npm install
  • Run npm run gen from the root of the project or from examples dir
  • See the same error as the screenshot above

Misc

  • Node version: 18.20.3
  • Package manager: pnpm
  • Browser: Chrome
  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖

I was hitting my head for an hour trying to figure this one out. When I comment out fs.writeFileSync the error is gone, and this seems to be originating from the way we're getting the path/dir :

const dir = path.parse(import.meta.url.replace("file://", "")).dir;

This issue is in every instance of the above code, in gen.ts, genDocs.ts, and util.ts


I was only able to generate the example code in #954 using my MacOS. So this issue is exclusively on Windows.

@zaaakher zaaakher added the bug Something isn't working label Jul 19, 2024
@jkcs
Copy link
Contributor

jkcs commented Jul 19, 2024

need change

import { fileURLToPath } from "url";

const dir = path.parse(fileURLToPath(import.meta.url)).dir;

@zaaakher
Copy link
Contributor Author

zaaakher commented Jul 19, 2024

@jkcs That silenced the error but it doesn't seem to be actually generating the examples.gen.tsx due to getExampleProjects not finding any example files due to it not knowing the exact path

@jkcs
Copy link
Contributor

jkcs commented Jul 22, 2024

@zaaakher
Copy link
Contributor Author

zaaakher commented Jul 22, 2024

try this:https://github.com/TypeCellOS/BlockNote/pull/818/files#diff-93421da21c480705d1154839957c6737a254abe9cc85a0e91f792ce42627e17e

That only silenced the errors. But unfortunately it can't read any example directories which makes it output an empty example object in examples.gen.tsx

@matthewlipski
Copy link
Collaborator

Ah yeah, I was also running into this when I was working on Windows way back. Basically, node:path handles Windows and MacOS paths pretty differently and it's just kind of a pain. Unfortunately the solution that was most convenient for me was removing all path calls and replacing them with hardcoded strings:(

@YousefED
Copy link
Collaborator

/bounty 10

Copy link

algora-pbc bot commented Jul 29, 2024

💎 $10 bounty • BlockNote

Steps to solve:

  1. Start working: Comment /attempt #955 with your implementation plan
  2. Submit work: Create a pull request including /claim #955 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to TypeCellOS/BlockNote!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @rogueloop Jul 29, 2024, 10:26:48 PM WIP
🟢 @jkcs #970

@rogueloop
Copy link

rogueloop commented Jul 29, 2024

/attempt #955

Algora profile Completed bounties Tech Active attempts Options
@rogueloop 1 bounty from 1 project
Java, Go,
Python & more
Cancel attempt

Copy link

algora-pbc bot commented Jul 30, 2024

💡 @jkcs submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Aug 6, 2024

@jkcs: You've been awarded a $10 bounty by BlockNote! We'll notify you once it is processed.

Copy link

algora-pbc bot commented Aug 31, 2024

🎉🎈 @jkcs has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty bug Something isn't working 💰 Rewarded
Projects
None yet
5 participants