Merging to release-5-lts: [TT-9829] Fix checking json.Marshal errors in tests (#5426) #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit c985ee4)
|
Kudos, SonarCloud Quality Gate passed! |
buger
deleted the
merge/release-5-lts/c985ee423b31d6106223be934bc72f024cfe0180
branch
|
API tests result: success ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-9829 Fix checking json.Marshal errors in tests (#5426)
test.MarshalJSONutility for encoding json in tests andasserting the error return is nil,
This is required to resolve some sonarcloud errors in existing tests
code.
https://tyktech.atlassian.net/browse/TT-9829
Co-authored-by: Tit Petric tit@tyk.io