[TT-9829] Fix checking json.Marshal errors in tests #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titpetric
changed the title
|
API tests result: success ✅ |
|
API tests result: success ✅ |
|
💔 The detected issue is not in one of the allowed statuses 💔
Please ensure your jira story is in one of the allowed statuses |
|
API tests result: success ✅ |
|
API tests result: success ✅ |
titpetric
force-pushed
the
fix/tests-json-marshalling
branch
from
a5e466d to
c4231ad
Compare
|
I'm a bot and I 👍 this PR title. 🤖 |
|
SonarCloud Quality Gate failed.
|
|
API tests result: success ✅ |
jeffy-mathew
approved these changes
Aug 17, 2023
|
/release to release-5-lts |
|
Working on it! Note that it can take a few minutes. |
|
@titpetric Succesfully merged PR |
tykbot bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
- Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit c985ee4)
buger
added a commit
that referenced
this pull request
Aug 17, 2023
…in tests (#5426) [TT-9829] Fix checking json.Marshal errors in tests (#5426) - Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io>
|
/release to release-5.2 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
- Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit c985ee4)
|
@titpetric Succesfully merged PR |
buger
added a commit
that referenced
this pull request
Aug 17, 2023
… tests (#5426) [TT-9829] Fix checking json.Marshal errors in tests (#5426) - Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io>
|
/release to release-4-lts |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
- Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit c985ee4)
|
@titpetric Succesfully merged PR |
titpetric
added a commit
that referenced
this pull request
Nov 7, 2023
- Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit c985ee4)
titpetric
added a commit
that referenced
this pull request
Nov 7, 2023
…in tests (#5426) (#5751) [TT-9829] Fix checking json.Marshal errors in tests (#5426) - Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> [TT-9829]: https://tyktech.atlassian.net/browse/TT-9829?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Tit Petric <tit.petric@monotek.net> Co-authored-by: Tit Petric <tit@tyk.io>
lghiur
pushed a commit
that referenced
this pull request
Jan 22, 2024
…in tests (#5426) (#5751) [TT-9829] Fix checking json.Marshal errors in tests (#5426) - Added `test.MarshalJSON` utility for encoding json in tests and asserting the error return is nil, - Updated usage in tests This is required to resolve some sonarcloud errors in existing tests code. https://tyktech.atlassian.net/browse/TT-9829 --------- Co-authored-by: Tit Petric <tit@tyk.io> [TT-9829]: https://tyktech.atlassian.net/browse/TT-9829?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Tit Petric <tit.petric@monotek.net> Co-authored-by: Tit Petric <tit@tyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-9829
test.MarshalJSONutility for encoding json in tests and asserting the error return is nil,This is required to resolve some sonarcloud errors in existing tests code.
https://tyktech.atlassian.net/browse/TT-9829