Skip to content

CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#2802

Draft
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-04-09-00-46-39-902-03497967369
Draft

CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#2802
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-04-09-00-46-39-902-03497967369

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 9, 2026

This pull request changes the compat entry for the SciMLBase package from 2 to 2, 3.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2026-04-09-00-46-39-902-03497967369 branch from 82458a3 to d2a7721 Compare April 9, 2026 00:46
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 9, 2026

Turing.jl documentation for PR #2802 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2802/

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.45%. Comparing base (ab29465) to head (d2a7721).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          22       22           
  Lines        1454     1454           
=======================================
  Hits         1257     1257           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm
Copy link
Copy Markdown
Member

Note that the successful CI run was with SciMLBase@2

@penelopeysm penelopeysm marked this pull request as draft April 9, 2026 10:49
@penelopeysm
Copy link
Copy Markdown
Member

penelopeysm commented Apr 9, 2026

This PR cannot be merged: Optimization is not yet compatible with SciMLBase@3

Edit: see SciML/Optimization.jl#1179 for upstream progress

@ChrisRackauckas-Claude
Copy link
Copy Markdown

Courtesy note from the SciMLBase v3 ecosystem sweep: this PR is low-risk from the v3 breaking-surface perspective. A grep of src/ and test/ for the main v3 flags came up clean — no u_modified! call sites, no DEProblem type references, no 3-arg ensemble prob_func, no single-int timeseries sol[i] indexing. Turing's SciMLBase usage appears limited to the OptimizationSolution type in src/optimisation/Optimisation.jl, which is unaffected by v3.

One ecosystem-wide caveat: Pkg.resolve() fails on any env containing SciMLBase 3.1 right now because OrdinaryDiffEq still pins RecursiveArrayTools ≤ 3.54 while SciMLBase 3.1 requires RAT v4. Expect CI here to fail at the Pkg.add step until upstream OrdinaryDiffEq releases a RAT-v4-compatible version; re-running afterward should go green.

For reference, the SciML-side pattern PR with full breaking-change context is SciML/DiffEqCallbacks.jl#300.

cc @ChrisRackauckas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants