Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen Optimization compat to v4, and related packages accordingly #2327

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Widen Optimization compat to v4, and related packages accordingly #2327

merged 1 commit into from
Sep 25, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Sep 23, 2024

Supersedes a bunch of CompatHelper PRs that did this bit-by-bit.

This was referenced Sep 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.43%. Comparing base (78d110a) to head (bd8a237).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (78d110a) and HEAD (bd8a237). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (78d110a) HEAD (bd8a237)
111 108
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2327       +/-   ##
===========================================
- Coverage   86.80%   57.43%   -29.38%     
===========================================
  Files          24       24               
  Lines        1599     1588       -11     
===========================================
- Hits         1388      912      -476     
- Misses        211      676      +465

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10990803250

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 460 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-29.3%) to 57.758%
Files with Coverage Reduction New Missed Lines %
src/mcmc/emcee.jl 2 90.2%
src/variational/VariationalInference.jl 4 14.29%
src/mcmc/gibbs.jl 4 94.05%
src/mcmc/particle_mcmc.jl 10 87.84%
src/mcmc/gibbs_conditional.jl 12 0.0%
src/mcmc/Inference.jl 18 77.3%
ext/TuringDynamicHMCExt.jl 29 0.0%
src/mcmc/mh.jl 32 57.43%
ext/TuringOptimExt.jl 50 0.0%
src/variational/advi.jl 53 0.0%
Totals Coverage Status
Change from base Build 10703372980: -29.3%
Covered Lines: 912
Relevant Lines: 1579
💛 - Coveralls

torfjelde
torfjelde approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely @mhauru :)

@penelopeysm penelopeysm merged commit 1c98784 into master Sep 25, 2024
57 of 60 checks passed
@penelopeysm penelopeysm deleted the mhauru/optimization4-compat branch September 25, 2024 11:19
@penelopeysm
Copy link
Member

merging so that compathelper doesn't reopen the same prs again

@mhauru
Copy link
Member Author

mhauru commented Sep 25, 2024

The tests seemed to be failing. Did we understand why?

@penelopeysm
Copy link
Member

Seems to be upstream method ambiguities JuliaDiff/ForwardDiff.jl#681

@penelopeysm
Copy link
Member

Will revert

penelopeysm added a commit that referenced this pull request Sep 25, 2024
@penelopeysm
Revert "Bump Optimization to v4, and related packages accordingly (#2327
b2f1aa6 
)"

This reverts commit 1c98784.
@penelopeysm penelopeysm mentioned this pull request Sep 25, 2024
Merged
penelopeysm added a commit that referenced this pull request Sep 26, 2024
@penelopeysm
Revert "Bump Optimization to v4, and related packages accordingly (#2327
3c91eec 
)" (#2343)

This reverts commit 1c98784.
@penelopeysm penelopeysm restored the mhauru/optimization4-compat branch September 26, 2024 10:29
@penelopeysm penelopeysm mentioned this pull request Sep 27, 2024
Merged
penelopeysm added a commit that referenced this pull request Sep 27, 2024
@penelopeysm
Reapply "Bump Optimization to v4, and related packages accordingly (#…
1950688 
…2327)" (#2343)

This reverts commit 3c91eec.
@yebai yebai deleted the mhauru/optimization4-compat branch October 23, 2024 16:22
penelopeysm added a commit that referenced this pull request Oct 24, 2024
@penelopeysm @mhauru @yebai
Bump Optimization to v4, and related packages accordingly (#2354)
08331c5 
* Reapply "Bump Optimization to v4, and related packages accordingly (#2327)" (#2343)

This reverts commit 3c91eec.

* Unmark Mooncake as broken on Optimization v4

---------

Co-authored-by: Markus Hauru <markus@mhauru.org>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhauru @coveralls @penelopeysm @torfjelde