Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for OptimizationOptimJL to 0.4, (keep existing compat) #2321

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the OptimizationOptimJL package from 0.1, 0.2, 0.3 to 0.1, 0.2, 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-21-00-29-46-555-02156421162 branch from 64c1c88 to ec1cf24 Compare September 21, 2024 00:29
@penelopeysm penelopeysm reopened this Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (78d110a) to head (ec1cf24).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
+ Coverage   86.80%   86.86%   +0.06%     
==========================================
  Files          24       24              
  Lines        1599     1599              
==========================================
+ Hits         1388     1389       +1     
+ Misses        211      210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10972641167

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.085%

Totals Coverage Status
Change from base Build 10703372980: 0.06%
Covered Lines: 1389
Relevant Lines: 1595

💛 - Coveralls

@mhauru
Copy link
Member

mhauru commented Sep 23, 2024

Superseded by #2327

@mhauru mhauru closed this Sep 23, 2024
@yebai yebai deleted the compathelper/new_version/2024-09-21-00-29-46-555-02156421162 branch September 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants