Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accepted arg to AdvancedMH.Transition calls #2172

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add accepted arg to AdvancedMH.Transition calls #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d547e8
add `accepted` field
sunxd3 Feb 16, 2024
6d2f291
remove unintentional push
sunxd3 Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcmc/emcee.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
vis[1],
map(vis) do vi
vi = DynamicPPL.link!!(vi, spl, model)
AMH.Transition(vi[spl], getlogp(vi))
AMH.Transition(vi[spl], getlogp(vi), false)

Check warning on line 61 in src/mcmc/emcee.jl

View check run for this annotation

Codecov / codecov/patch

src/mcmc/emcee.jl#L61 

Added line #L61 was not covered by tests
end
)

Expand Down
4 changes: 2 additions & 2 deletions src/mcmc/mh.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@

# Create a sampler and the previous transition.
mh_sampler = AMH.MetropolisHastings(dt)
prev_trans = AMH.Transition(vt, getlogp(vi))
prev_trans = AMH.Transition(vt, getlogp(vi), false)

Check warning on line 389 in src/mcmc/mh.jl

View check run for this annotation

Codecov / codecov/patch

src/mcmc/mh.jl#L389 

Added line #L389 was not covered by tests

# Make a new transition.
densitymodel = AMH.DensityModel(
Expand Down Expand Up @@ -421,7 +421,7 @@

# Create a sampler and the previous transition.
mh_sampler = AMH.MetropolisHastings(spl.alg.proposals)
prev_trans = AMH.Transition(vals, getlogp(vi))
prev_trans = AMH.Transition(vals, getlogp(vi), false)

Check warning on line 424 in src/mcmc/mh.jl

View check run for this annotation

Codecov / codecov/patch

src/mcmc/mh.jl#L424 

Added line #L424 was not covered by tests

# Make a new transition.
densitymodel = AMH.DensityModel(
Expand Down
Loading