-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accepted
arg to AdvancedMH.Transition
calls
#2172
Conversation
As I wrote in TuringLang/AdvancedMH.jl#88 this approach can easily lead to misleading/incorrect acceptance rates? |
The field |
Anyhow, this PR is to just patch the interface so that it won't error. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2172 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1385 1385
======================================
Misses 1385 1385 ☔ View full report in Codecov by Sentry. |
Can we print a warning message indicating that the acceptance rate might be inaccurate if thinning or discarding warmup is applied? |
test_code.jl
Outdated
@@ -0,0 +1,126 @@ | |||
using Turing, Enzyme, LogDensityProblems, LogDensityProblemsAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use a more informative file name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry, this file should not be here, it was a local script, I'll remove it
Reflect TuringLang/AdvancedMH.jl#88