[Merged by Bors] - Fixes for Julia 1.6 #212
Conversation
|
bors try |
|
The coverage drop is real, somehow I managed to disable the Turing tests completely... |
|
bors try |
That fixes the test failures, at any rate 😉 |
|
OK, I fixed it. |
| # (not added automatically on Julia 1.3, see e.g. PR #209) | ||
| if !(joinpath(DIRECTORY_Turing_tests, "Project.toml") in Base.load_path()) | ||
| pushfirst!(LOAD_PATH, DIRECTORY_Turing_tests) | ||
| @static if VERSION <= v"1.5.3" |
There was a problem hiding this comment.
Are we going to remove this flag after Turing is 1.5.3 compatible? Or is Libtask still the hangup here?
There was a problem hiding this comment.
Turing and Libtask are fine with 1.5.3, only with Julia 1.6 and nightlies Julia segfaults. I am pretty sure it is only due to Libtask, in particular since the model with NUTS in the linked issue runs on Julia 1.6 without any problems.
There was a problem hiding this comment.
Okay. Let's revisit this flag when the 1.6 release candidate is out.
| # (not added automatically on Julia 1.3, see e.g. PR #209) | ||
| if !(joinpath(DIRECTORY_Turing_tests, "Project.toml") in Base.load_path()) | ||
| pushfirst!(LOAD_PATH, DIRECTORY_Turing_tests) | ||
| @static if VERSION <= v"1.5.3" |
There was a problem hiding this comment.
Okay. Let's revisit this flag when the 1.6 release candidate is out.
|
bors r+ |
This PR fixes TuringLang/Turing.jl#1525 (comment) and fixes the model definition and some warning on Julia 1.6. It also includes a line number node of the call site instead of a reference to `src/compiler.jl` in the model definition for easier debugging. On Julia 1.6, initially I got warnings about method redefinitions (models of the same name) that all referred to line 344 in `src/compiler.jl` instead of the place where the model was defined by the user. Turing tests are disabled currently since they crash (segmentation fault). Might be related to the fact that Libtask is not compatible with Julia 1.6 yet (therefore also an older version of Turing and Libtask would be used on Julia 1.6). Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
This PR fixes TuringLang/Turing.jl#1525 (comment) and fixes the model definition and some warning on Julia 1.6. It also includes a line number node of the call site instead of a reference to
src/compiler.jlin the model definition for easier debugging. On Julia 1.6, initially I got warnings about method redefinitions (models of the same name) that all referred to line 344 insrc/compiler.jlinstead of the place where the model was defined by the user.Turing tests are disabled currently since they crash (segmentation fault). Might be related to the fact that Libtask is not compatible with Julia 1.6 yet (therefore also an older version of Turing and Libtask would be used on Julia 1.6).