Warn when concretising a dynamic index on a GrowableArray & when creating a GrowableArray#1253
Merged
penelopeysm merged 5 commits intobreakingfrom Feb 4, 2026
Merged
Warn when concretising a dynamic index on a GrowableArray & when creating a GrowableArray#1253penelopeysm merged 5 commits intobreakingfrom
penelopeysm merged 5 commits intobreakingfrom
Conversation
Contributor
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## breaking #1253 +/- ##
=============================================
+ Coverage 36.98% 78.57% +41.59%
=============================================
Files 46 46
Lines 3572 3608 +36
=============================================
+ Hits 1321 2835 +1514
+ Misses 2251 773 -1478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e25a1b to
40d9f0d
Compare
Contributor
|
DynamicPPL.jl documentation for PR #1253 is available at: |
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1241
Closes #1251
With this PR:
Previously neither of these would warn.