Many of the VNT tests were written prior to shadow arrays. I updated a number of them to use shadow arrays and templated_setindex!!, but there are probably still a lot of tests that use untemplated setindex!!.
Following #1241 and #1253 all of these calls now issue warnings, which is not a fatal problem, but kind of annoying.
We also don't expect that people will be using untemplated setindex!! very much (there's now a dedicated macro to help users construct templated VNTs more easily, plus tons of docs pages on this). So I think it would be sensible to go through the tests and see where we can remove those calls to untemplated setindex!!, or preferably, replace them with templated_setindex!! or just direct calls to @vnt.
Many of the VNT tests were written prior to shadow arrays. I updated a number of them to use shadow arrays and
templated_setindex!!, but there are probably still a lot of tests that use untemplatedsetindex!!.Following #1241 and #1253 all of these calls now issue warnings, which is not a fatal problem, but kind of annoying.
We also don't expect that people will be using untemplated
setindex!!very much (there's now a dedicated macro to help users construct templated VNTs more easily, plus tons of docs pages on this). So I think it would be sensible to go through the tests and see where we can remove those calls to untemplatedsetindex!!, or preferably, replace them withtemplated_setindex!!or just direct calls to@vnt.