Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompatHelper: bump compat for "Zygote" to "0.6" for package test #143

Merged
merged 4 commits into from
Jan 6, 2021
Merged

CompatHelper: bump compat for "Zygote" to "0.6" for package test #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf8ada7
CompatHelper: bump compat for "Zygote" to "0.6" for package test
github-actions[bot] Dec 22, 2020
d4be353
Mark `Skellam`, `Pareto`, and `NormalInverseGaussian` as broken
devmotion Jan 5, 2021
6e5b02f
Fix type error
devmotion Jan 5, 2021
e976895
Remove Pareto test case
devmotion Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ ReverseDiff = "1.4.4"
StatsBase = "0.33.2"
StatsFuns = "0.9.6"
Tracker = "0.2.12"
Zygote = "0.5.13"
Zygote = "0.5.13, 0.6"
julia = "1.3"
12 changes: 7 additions & 5 deletions test/ad/distributions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
DistSpec(Poisson, (0.5,), 1),
DistSpec(Poisson, (0.5,), [1, 1]),

DistSpec(Skellam, (1.0, 2.0), -2),
DistSpec(Skellam, (1.0, 2.0), [-2, -2]),
DistSpec(Skellam, (1.0, 2.0), -2; broken=(:Zygote,)),
DistSpec(Skellam, (1.0, 2.0), [-2, -2]; broken=(:Zygote,)),

DistSpec(PoissonBinomial, ([0.5, 0.5],), 0),
DistSpec(PoissonBinomial, ([0.5, 0.5],), [0, 0]),
Expand Down Expand Up @@ -167,9 +167,8 @@

DistSpec(NormalCanon, (1.0, 2.0), 0.5),

DistSpec(NormalInverseGaussian, (1.0, 2.0, 1.0, 1.0), 0.5),
DistSpec(NormalInverseGaussian, (1.0, 2.0, 1.0, 1.0), 0.5; broken=(:Zygote,)),

DistSpec(Pareto, (), 1.5),
DistSpec(Pareto, (1.0,), 1.5),
DistSpec(Pareto, (1.0, 1.0), 1.5),

Expand Down Expand Up @@ -219,6 +218,9 @@
# Stackoverflow caused by SpecialFunctions.besselix
DistSpec(VonMises, (1.0,), 1.0),
DistSpec(VonMises, (1, 1), 1),

# Only some Zygote tests are broken and therefore this can not be checked
DistSpec(Pareto, (), 1.5; broken=(:Zygote,)),
]

# Tests that have a `broken` field can be executed but, according to FiniteDifferences,
Expand Down Expand Up @@ -394,7 +396,7 @@

# Skellam only fails in these tests with ReverseDiff
# Ref: https://github.com/TuringLang/DistributionsAD.jl/issues/126
filldist_broken = d.f(d.θ...) isa Skellam ? (:ReverseDiff,) : d.broken
filldist_broken = d.f(d.θ...) isa Skellam ? (d.broken..., :ReverseDiff) : d.broken
arraydist_broken = d.broken

# Create `filldist` distribution
Expand Down