Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Zygote" to "0.6" for package test #143

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Zygote package from 0.5.13 to 0.5.13, 0.6 for package test.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2020-12-22-00-28-48-132-2058375424 branch from 18a01fb to cf8ada7 Compare December 22, 2020 00:28
@devmotion
Copy link
Member

See FluxML/NNlib.jl#251.

@devmotion devmotion closed this Jan 4, 2021
@devmotion devmotion reopened this Jan 4, 2021
@devmotion
Copy link
Member

It is not possible to compute the derivative of logpdf(::Skellam, x::Real) with respect to x with ChainRules currently since it involves taking the derivative of besseli with respect to the order which is not implemented currently: https://github.com/JuliaMath/SpecialFunctions.jl/blob/d18ff04178dd37a60cc716a60ab3caf1a6903f43/src/chainrules.jl#L41

@devmotion
Copy link
Member

This affects more distributions: FluxML/Zygote.jl#873

@devmotion
Copy link
Member

Looks good, as discussed in TuringLang/Bijectors.jl#155 tests are marked as broken for now.

@devmotion devmotion merged commit cd7f120 into master Jan 6, 2021
@devmotion devmotion deleted the compathelper/new_version/2020-12-22-00-28-48-132-2058375424 branch January 6, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant