Add ramping and unit commitment basic constraints

[clizbe]

Pull request details

Describe the changes made in this pull request

List of related issues or pull requests

Closes #724

Collaboration confirmation

As a contributor I confirm

• I read and followed the instructions in README.dev.md
• The documentation is up to date with the changes introduced in this Pull Request (or NA)
• Tests are passing
• Lint is passing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a447277) to head (7c5cb20).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #726   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        18    +1     
  Lines          755       842   +87     
=========================================
+ Hits           755       842   +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datejada]

@clizbe, the latest changes in the main branch conflict with your changes here for this development. They should be easy to resolve, but if you need some guidance or help, please let @abelsiqueira or me know.

[clizbe]

@datejada I think I rebased correctly.
But also I've gotten busy with a lot of other stuff before my vacation. Can we hand off and you continue it? I left a lot of notes in the code, but I can also explain it.

[datejada]

@datejada I think I rebased correctly. But also I've gotten busy with a lot of other stuff before my vacation. Can we hand off and you continue it? I left a lot of notes in the code, but I can also explain it.

I got you! No worries 😉

[abelsiqueira]

Thanks for the PR. I've made some comments in various places.
I see there are no changes to the tests (not the test data). Is that expected? The coverage passed, so the constrains are supposed to be generated. I imagine there is no easy way to test this, so I will leave to your decision.

[datejada]

Thanks for the PR. I've made some comments in various places. I see there are no changes to the tests (not the test data). Is that expected? The coverage passed, so the constrains are supposed to be generated. I imagine there is no easy way to test this, so I will leave to your decision.

Correct! The constraints are tested through the case study. It is not a bulletproof way to do it, but we need to come up with something simple to test the functions that creates the constraints that do not depend on the case studies. I will make an issue for that because we would like to be sure we test and get what we want. This might be a good thing to do after the refactoring. Thanks!

[abelsiqueira]

Thanks!