New collector; telemetry discussion #265 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 81.73% 81.67% -0.06%
==========================================
Files 195 195
Lines 10624 10631 +7
==========================================
Hits 8683 8683
- Misses 1644 1651 +7
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
reuvenharrison
approved these changes
Sep 17, 2023
| @@ -70,7 +71,14 @@ func strategy() func(*cobra.Command) int { | |||
| c := make(chan int) | |||
| go func() { | |||
| defer close(c) | |||
| _ = client.NewCollector().Send(cmd) | |||
| _ = client.NewCollector(util.NewStringSet().Add("err-ignore"). | |||
There was a problem hiding this comment.
Ideally, we should generate this list automatically from the flags so that we don't need to remember to update this every time a new flag is added.
I'll open an enhancement issue to remind us.
effoeffi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
telemetry discussion #265