Add 404 page #411
Closed
Add 404 page #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A very simple 404 page styled with the current theme (added some padding but that's it). Sent as a static file instead of a view to prevent us having to duplicate it on the theme and the admin side for now.
|
Does this satisfy #356 or should I close this in favor of that getting implemented? |
|
#356 is intended to add 404 support across the whole application not just if a post cannot be found. I would merge this for the time being but I want to get @JohnONolan's signoff on the appearance of the 404 page before I do :) |
|
I'm back online. :) We should probably focus on the systems for integrating 404s, since users will definitely want to theme their own, and we'll want a flexible system in place to support that (but still have the ghost-themed 404 for admin routes.) |
Merged
|
Closing in favor of #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple 404 page styled with the current theme (added some padding
but that's it). Sent as a static file instead of a view to prevent us
having to duplicate it on the theme and the admin side for now.
Closes #409.