-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 error handling for admin & blog #356
Milestone
Comments
Happy to take this one. |
Thanks, @JohnONolan. I'll plug that in. :) |
Still want this? The API stuff is way more important and quite a big chunk of work ;) |
I want something small so I can get my head back into ghost-space. Small issues are good for me over the next couple of days, so I can feel like I'm achieving something. Then I'll attack the API. :) |
🍩 🍰 |
Done. Just about to push. Finally! |
cgiffard
referenced
this issue
in cgiffard/Ghost
Sep 17, 2013
Fixes #356 - Adds new generic methods for handling errors to errorHandling.js - Initialises generic methods as middleware - Created error.hbs view in admin - Error handler searches for error.hbs view file in user theme folder and renders it if available, otherwise lets the error fall through to express. - We *could* change the final behaviour to render a default ghost template should the user template be missing - Because it currently isn't possible to require(ghost) in errorHandling.js, it was necessary to duplicate some aspects of the ghost path init code inside errorhandling.js. This should be cleaned up and moved back into ghost.js when possible.
daniellockyer
pushed a commit
that referenced
this issue
Jul 20, 2022
refs https://github.com/TryGhost/Team/issues/1037 Tiers have a new `type` column to differentiate between `free` and `paid` tiers. This change - - sets type as paid for all new tiers created, as `free` tier is created by default - excludes any price/stripe data change for free tier - updates all usages of default product to fetch the first paid product from the products list in DB instead of just the first product it finds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behaviour:
If you navigate to /ghost/fsdf you receive an error message
Cannot GET /ghost/fsdf
Desired Behaviour:
Serve a template which says
Ghost 404 Page Not Found
and that we can edit with a nice design later.Current Behaviour:
If you navigate to /fsdf (assuming there is no post with that slug) the page spins.
Desired Behaviour:
If the theme does not provide a 404.hbs template, then serve our Ghost 404 template.
The text was updated successfully, but these errors were encountered: