Pretty substantial re-write / re-structure #9
Conversation
|
What's the point of update? Please explain this changes. |
|
Pushing the version to PHP 7.1 syntax so that people using the client are on the latest supported version of PHP. https://www.php.net/supported-versions.php I've also altered a little bit of the logic to prevent duplicate code by implementing an abstract class for GroupedModels. |
… they're empty or not.
composer.json
Outdated
| "php-http/message": "^1.2", | ||
| "guzzlehttp/psr7": "^1.3" | ||
| "guzzlehttp/psr7": "^1.3", | ||
| "leedavis81/vent": "dev-master", |
There was a problem hiding this comment.
Please use other solution since this is old bundle and there is no stable version.
|
Updates:
|
|
@cjmaxik This is all working as to be expected now. Please check the build to see why it failed (not an error with the code). |
| php: | ||
| - 5.6 | ||
| - 7.0 | ||
| - 7.1 |
There was a problem hiding this comment.
Add 7.2 and (maybe) 7.3, remove hhvm
| class ClientTest extends TestCase | ||
| { | ||
| private $testAccount = 585204; | ||
| const TEST_ACCOUNT = 585204; |
There was a problem hiding this comment.
We should add a proper test account for production (maybe even several accounts for checking private states)
| $servers = $this->client->servers(); | ||
|
|
||
| $this->assertEquals($servers[0]->name, 'Europe 1'); | ||
| $this->assertEquals($servers->getServers()[0]->getName(), 'Europe 1 [Simulation]'); |
There was a problem hiding this comment.
This should be streamlined for the cases if we will change server names.
| */ | ||
| public function __construct(array $config = [], bool $secure = true) | ||
| { | ||
| $scheme = $secure ? 'https' : 'http'; |
There was a problem hiding this comment.
Should the scheme be always secure?
|
Closing this pull request due to inactivity. Additionally, this was replaced and extended by the new pull request; #12. |
Rework of the library This PR continues on from and extends #9 which has been closed due to inactivity. * Seperated the tests into individual test classes * Removed hhvm from Travis CI config * Set the schema to always use HTTPS * Changed the way each request is handled (you can refer to the wiki for more information) * We now have a model to represent each API endpoint including new properties * Simplified the README.md * Added extended documentation via the wiki * Removed the examples from the package (the wiki has plenty of examples) * Updated composer dependencies to the latest version * Set the minimum PHP version to PHP 7.2 * Added PHP 7.2 and PHP 7.4 to the Travis CI config
3 participants
Worth noting that this will require a major version bump.